fix: correct zsh _arguments syntax in completion script#22713
Closed
Ninso112 wants to merge 2 commits into
Closed
Conversation
When a user replies using Telegram's native quote feature to select only part of a previous message, the adapter was ignoring message.quote and injecting the entire replied-to message as reply_to_text. This could materially change the user's intent by exposing unrelated text to the agent. Now checks for message.quote (TextQuote) first and uses quote.text when available, falling back to the full reply_to_message.text only when no native quote exists. Fixes NousResearch#22619
The generated zsh completion script used invalid _arguments syntax
like '(-h --help){-h,--help}[...]' which causes zsh to reject the
script with 'invalid argument' errors. The exclusion group () must
contain only short options, not long options with spaces.
Changed to '(-)'{-h,--help}'[...]' which is the correct zsh syntax
where (-) means the option can be combined with any other option.
Also added a zsh syntax validation test (zsh -n) to prevent
regressions, matching the existing bash and fish syntax tests.
Fixes NousResearch#22686
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_argumentssyntax in the generated zsh completion script that caused zsh to reject it withinvalid argumenterrorszsh -nsyntax validation test to prevent future regressions (matching existing bash/fish tests)What changed
The zsh completion generator produced lines like:
'(-h --help){-h,--help}[Show help and exit]'This is invalid because
_argumentsexclusion groups()must contain only short options, not long options with spaces. The correct syntax is:Where
(-)means the option can be combined with any other option.Why
Users with zsh shell integration get a broken completion script on every invocation of
hermes completion zsh. The fix follows zsh's official completion syntax guidelines.Closes #22686.