fix(completion): correct zsh _arguments syntax for options with short and long forms#22701
Closed
Ninso112 wants to merge 1 commit into
Closed
fix(completion): correct zsh _arguments syntax for options with short and long forms#22701Ninso112 wants to merge 1 commit into
Ninso112 wants to merge 1 commit into
Conversation
… and long forms
The generated zsh completion script used invalid _arguments syntax:
'(-h --help){-h,--help}[...]'. Zsh () groups must contain only single-letter
short options, not long options with spaces. Changed to '(-)'{-h,--help}'[...]'
which is the standard zsh completion convention.
Closes NousResearch#22686
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_argumentssyntax in generated zsh completion script(-h --help){-h,--help}[...]is rejected by zsh because()groups cannot contain long options with spaces(-)'{-h,--help}'[...]which is the standard zsh completion conventionCloses #22686