fix(telegram): exclude row-label column from bullet items in table re…#22610
Merged
ethernet8023 merged 1 commit intoMay 9, 2026
Conversation
…ndering When a GFM table has a row-label column (first column with no header), _render_table_block_for_telegram incorrectly included the row-label cell in the bullet zip alongside the data cells, producing a spurious bullet like '• 維度: 核心賣點' before the real data rows. Detect the row-label column by comparing the first data row cell count against the header count (has_row_label_col = len(first_data_row) == len(headers) + 1). When present, use cells[0] as the heading and zip headers against cells[1:] only, correctly excluding the row-label from the bullet list. Fixes NousResearch#22604
ethernet8023
approved these changes
May 9, 2026
This was referenced May 9, 2026
JinyuID
pushed a commit
to JinyuID/hermes-agent
that referenced
this pull request
May 11, 2026
…ble-row-label-duplicate-bullet fix(telegram): exclude row-label column from bullet items in table re…
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
…ble-row-label-duplicate-bullet fix(telegram): exclude row-label column from bullet items in table re…
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
May 25, 2026
…ble-row-label-duplicate-bullet fix(telegram): exclude row-label column from bullet items in table re…
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…ble-row-label-duplicate-bullet fix(telegram): exclude row-label column from bullet items in table re…
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…ble-row-label-duplicate-bullet fix(telegram): exclude row-label column from bullet items in table re…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a rendering bug in
_render_table_block_for_telegramwhere GFM tables with a row-label column produce a spurious duplicate bullet item.When a table has a row-label column (first column with no header), the row-label cell was incorrectly included in the bullet
zipalongside the data cells. This produced an extra bullet like• 維度: 核心賣點before the real data rows.Root cause: The function compared
len(cells)againstlen(headers)and trimmed/padded without accounting for the row-label column, so the row-label cell ended up in both the bold heading and the first bullet.Fix: Detect the row-label column by checking if the first data row has exactly one more cell than the header row (
has_row_label_col = len(first_data_row) == len(headers) + 1). When true, usecells[0]as the heading and zipheadersagainstcells[1:]only.Type of Change
References
Fixes #22604
Checklist