fix(voice): honor PULSE_SERVER/PIPEWIRE_REMOTE inside Docker (#21203) by wesleysimplicio · Pull Request #22534 · NousResearch/hermes-agent

wesleysimplicio · 2026-05-09T11:55:16Z

What does this PR do?

detect_audio_environment() unconditionally added a hard warning when running inside a Docker/Podman container, blocking /voice on even when the host PulseAudio/PipeWire socket was correctly mounted and sounddevice could enumerate devices (issue #21203).

Root cause

The detailed rationale from the original PR body is preserved below. This template update keeps the review structure consistent with #29640.

Fix

Mirror the existing WSL/PulseAudio handling at tools/voice_mode.py:110-125:

If is_container() and PULSE_SERVER or PIPEWIRE_REMOTE is set → downgrade to an informational notices entry (does not block voice).
If is_container() and neither is set → keep the hard block, but extend the message with the exact -v / -e flags users need.

No public surface changes. detect_audio_environment() still returns {available, warnings, notices}.

Why this shape

This shape mirrors #29640 so reviewers can quickly compare scope, root cause, fix, tests, and related context without having to decode a custom PR description.

Tests

Veja a descrição original preservada abaixo para detalhes de validação, testes e notas de verificação.

Original body

Related PRs / issues

Closes #21203

Original body

Summary

detect_audio_environment() unconditionally added a hard warning when running inside a Docker/Podman container, blocking /voice on even when the host PulseAudio/PipeWire socket was correctly mounted and sounddevice could enumerate devices (issue #21203).

What Changed

Standardized this PR body to the current Hermes Turbo template.
Preserved the original detailed description below for reference.

Fluxo

A mudança continua seguindo o fluxo original descrito na seção preservada abaixo, sem ampliar o escopo funcional deste PR.

Visão

A padronização melhora a revisão, reduz ruído e evita deriva de formatação entre PRs abertos.

Test Plan

Veja a descrição original preservada abaixo para detalhes de validação, testes e notas de verificação.

Original body

What does this PR do?

Summary

detect_audio_environment() unconditionally added a hard warning when running inside a Docker/Podman container, blocking /voice on even when the host PulseAudio/PipeWire socket was correctly mounted and sounddevice could enumerate devices (issue #21203).

Fix

Mirror the existing WSL/PulseAudio handling at tools/voice_mode.py:110-125:

If is_container() and PULSE_SERVER or PIPEWIRE_REMOTE is set → downgrade to an informational notices entry (does not block voice).
If is_container() and neither is set → keep the hard block, but extend the message with the exact -v / -e flags users need.

No public surface changes. detect_audio_environment() still returns {available, warnings, notices}.

Test plan

3 new regression tests in tests/tools/test_voice_mode.py::TestDetectAudioEnvironment:
- test_docker_with_pulse_server_allows_voice
- test_docker_with_pipewire_remote_allows_voice
- test_docker_without_audio_forwarding_blocks_voice
Stash-verified: all 3 fail on origin/main, pass with the fix.
Full file tests/tools/test_voice_mode.py: 63/63 pass.

Closes #21203

Solution Sketch

fix the root cause in the touched subsystem instead of layering a broad workaround around the symptom
keep surrounding behavior stable and avoid unrelated refactors while the area is under review
prove the change with focused checks on the exact path that regressed

Related Issue

Closes #21203

Type of Change

🐛 Bug fix (non-breaking change that fixes an issue)
✨ New feature (non-breaking change that adds functionality)
🔒 Security fix
📝 Documentation update
✅ Tests (adding or improving test coverage)
♻️ Refactor (no behavior change)
🎯 New skill (bundled or hub)

Changes Made

preserved the existing technical rationale and validation notes inside the template body
scoped this PR description to the implementation already present on the branch
aligned the delivery format with .github/PULL_REQUEST_TEMPLATE.md

How to Test

Review the existing validation notes preserved in this PR body.
Run the focused checks for the touched area.
Confirm the scoped change still behaves as described above.

Checklist

Code

I've read the Contributing Guide
My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
I searched for existing PRs to make sure this isn't a duplicate
My PR contains only changes related to this fix/feature (no unrelated commits)
I've run pytest tests/ -q and all tests pass
I've added tests for my changes (required for bug fixes, strongly encouraged for features)
I've tested on my platform:

Documentation & Housekeeping

I've updated relevant documentation (README, docs/, docstrings) — or N/A
I've updated cli-config.yaml.example if I added/changed config keys — or N/A
I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

N/A.

Generated by Hermes Turbo

…earch#21203) detect_audio_environment() unconditionally added a hard warning when running inside a container, blocking /voice on even when the host audio socket was correctly forwarded (PulseAudio or PipeWire) and sounddevice could enumerate devices. Mirror the existing WSL/PulseAudio handling: if PULSE_SERVER or PIPEWIRE_REMOTE is set, downgrade to a notice and let the audio backend decide. When neither is set, keep the block but extend the message with the exact -v / -e flags users need. Closes NousResearch#21203

Copilot

Pull request overview

This PR fixes voice-mode environment detection inside Docker/Podman containers so /voice on is not blocked when host PulseAudio/PipeWire forwarding is configured via PULSE_SERVER and/or PIPEWIRE_REMOTE (issue #21203).

Changes:

Downgrade the container warning to an informational notice when PULSE_SERVER or PIPEWIRE_REMOTE is set.
Keep the hard block when running in a container without audio forwarding, and extend the warning with suggested Docker flags.
Add 3 regression tests covering container scenarios with/without forwarding.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
`tools/voice_mode.py`	Adjusts container detection messaging/behavior to allow voice when audio forwarding env vars are present.
`tests/tools/test_voice_mode.py`	Adds regression tests for Docker container audio forwarding scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+        assert result["available"] is True
+        assert result["warnings"] == []
+        assert any("Docker" in n for n in result.get("notices", []))
+


+        assert result["available"] is True
+        assert result["warnings"] == []
+        assert any("Docker" in n for n in result.get("notices", []))
+


…mode-docker-respect-pulse-pipewire fix(voice): honor PULSE_SERVER/PIPEWIRE_REMOTE inside Docker (NousResearch#21203)

Copilot AI review requested due to automatic review settings May 9, 2026 11:55

Copilot started reviewing on behalf of wesleysimplicio May 9, 2026 11:55 View session

Copilot AI reviewed May 9, 2026

View reviewed changes

fix(voice_mode): generalize container phrasing and use $XDG_RUNTIME_DIR

30dd554

alt-glitch added type/bug Something isn't working area/docker Docker image, Compose, packaging tool/tts Text-to-speech and transcription P2 Medium — degraded but workaround exists labels May 11, 2026

daimon-nous Bot mentioned this pull request May 25, 2026

[Setup]: Audio in a docker container: Suggested solution with instructions #32009

Open

yu-xin-c mentioned this pull request May 25, 2026

docs: add Docker audio bridge notes #32122

Merged

benbarclay merged commit 81a4f28 into NousResearch:main May 27, 2026
10 of 13 checks passed

BrewTestBot mentioned this pull request May 28, 2026

hermes-agent 2026.5.28 Homebrew/homebrew-core#285115

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(voice): honor PULSE_SERVER/PIPEWIRE_REMOTE inside Docker (#21203)#22534

fix(voice): honor PULSE_SERVER/PIPEWIRE_REMOTE inside Docker (#21203)#22534
benbarclay merged 2 commits into
NousResearch:mainfrom
wesleysimplicio:fix/voice-mode-docker-respect-pulse-pipewire

wesleysimplicio commented May 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wesleysimplicio commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Root cause

Fix

Why this shape

Tests

Related PRs / issues

Summary

What Changed

Fluxo

Visão

Test Plan

What does this PR do?

Summary

Fix

Test plan

Solution Sketch

Related Issue

Type of Change

Changes Made

How to Test

Checklist

Code

Documentation & Housekeeping

Screenshots / Logs

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wesleysimplicio commented May 9, 2026 •

edited

Loading