fix gateway: clear slash confirm state during session boundary cleanup#22510
Merged
ethernet8023 merged 1 commit intoMay 9, 2026
Merged
Conversation
JinyuID
pushed a commit
to JinyuID/hermes-agent
that referenced
this pull request
May 11, 2026
…-confirm-boundary-cleanup fix gateway: clear slash confirm state during session boundary cleanup
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
…-confirm-boundary-cleanup fix gateway: clear slash confirm state during session boundary cleanup
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
May 25, 2026
…-confirm-boundary-cleanup fix gateway: clear slash confirm state during session boundary cleanup
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…-confirm-boundary-cleanup fix gateway: clear slash confirm state during session boundary cleanup
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…-confirm-boundary-cleanup fix gateway: clear slash confirm state during session boundary cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clear pending slash-confirm state when the gateway crosses a session boundary.
This fixes a state-leak where a pending
/reload-mcpconfirmation could survive/new,/resume, or/branchand still be resolved afterward in the reused session key.Problem
GatewayRunner._clear_session_boundary_security_state()already clears approval, YOLO, pending update-prompt, and skills-reload state, but it did not clear module-level pending state intools.slash_confirm.That meant an old slash-confirm prompt could outlive a conversation boundary and trigger side effects in the wrong session context.
Changes
tools.slash_confirmpending state inside session-boundary cleanupTesting
scripts/run_tests.sh tests/gateway/test_session_boundary_security_state.py5 passed in 6.25s