You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Salvaged via #22382 (now merged) and rebased onto current main with your authorship preserved — your commit landed as dbafa083b in the git history. Thanks @oferlaor!
A few notes for context: the salvage PR ended up rewriting the rationale around the consumers of HERMES_SESSION_* that actually drive this bug on current main (background-process notification routing in tools/terminal_tool.py, TTS format selection, per-platform skill caching, _check_send_message gating), rather than the access-control framing in your PR description — there is no per-identity toolset filter on main today (enabled_toolsets are passed straight to AIAgent), so the web/file/terminal strip you described isn't reproducible. That said, the mechanical fix is the right one for the consumer-routing reasons, and we landed it. Closes #22351.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/cronCron scheduler and job managementP2Medium — degraded but workaround existstype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix(cron): do not treat delivery origin as live gateway sender identity
Summary
HERMES_CRON_AUTO_DELIVER_*Why
Cron origin is routing metadata. Treating it as the live gateway sender can remove web/file/terminal tool schemas from authorized scheduled jobs.
Tests
python -m pytest tests/cron tests/tools/test_cronjob_tools.py -q -o 'addopts='Closes #22351