fix: normalize MiniMax OAuth expiry and portal URL#22258
Closed
steezkelly wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
Author
|
Closing this duplicate to reduce maintainer/CI noise. alt-glitch is right that this overlaps the existing MiniMax OAuth PR cluster (#20106/#22240 and related #19461/#19466/#20374/#22020/#21786).\n\nEvidence from comparing diffs:\n- #22258 changes the same files as the other candidates: hermes_cli/auth.py and tests/test_minimax_oauth.py.\n- #20106 already covers both platform.minimax.io URL normalization and epoch-ms expiry parsing with tests.\n- #22240 covers the epoch-ms expiry parsing path on a newer branch.\n\nThis PR added no sufficiently unique value to justify another competing branch. Maintainers should consolidate around one MiniMax OAuth fix rather than review/merge overlapping PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
www.minimax.ioto the usableplatform.minimax.iohost while preserving path/query.expired_invalues that arrive as Unix milliseconds into seconds-from-now.Test Plan
/home/steve/.hermes/hermes-agent/venv/bin/python -m pytest tests/test_minimax_oauth.py -q -o 'addopts='git diff --check