Skip to content

zsh completion fix#22234

Closed
rabkazoo wants to merge 1 commit into
NousResearch:mainfrom
rabkazoo:main
Closed

zsh completion fix#22234
rabkazoo wants to merge 1 commit into
NousResearch:mainfrom
rabkazoo:main

Conversation

@rabkazoo

@rabkazoo rabkazoo commented May 9, 2026

Copy link
Copy Markdown

Fixes invalid zsh _arguments syntax where braced option specs were wrapped inside a single quoted string, causing 'invalid argument' errors when pressing Tab.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels May 9, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing fix with #11754 and #21834 — all target the same zsh _arguments invalid syntax bug (#6122, #21829).

@teknium1

Copy link
Copy Markdown
Contributor

Closing in favor of PR #25075 (#25075). The _arguments quoting issue you fixed turned out not to reproduce on current main — the in-tree '(-)'{{-h,--help}}'...' form already expands correctly because the f-string {{ produces a literal { and the surrounding single quotes don't quote the brace expansion. The user-facing bug was the trailing _hermes "$@" blowing up on shell startup, which #25075 fixes. Thanks for the contribution.

@teknium1 teknium1 closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants