fix: generate zsh completion for compinit#21834
Closed
dbydd wants to merge 1 commit into
Closed
Conversation
This was referenced May 8, 2026
Closed
Contributor
|
Superseded by PR #25075 (#25075) which applies @ZeterMordio's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compinit/~/.zfunc/_hermesinstalls_argumentsspecs like{ -h,--help }with separate zsh option specs_hermes "$@"self-invocation from the generated completion filefpathinstall pathValidation
git diff --checkpython3 -m compileall hermes_cli/completion.py tests/hermes_cli/test_completion.py_hermes "$@"or{{-h,--help}}/{{-V,--version}}/{{-p,--profile}}~/.zfunc/_hermes+compinit:hermes <TAB>no longer raises_arguments:comparguments:327Notes
I intentionally kept the fix narrow: only zsh completion generation and regression tests changed. No provider config, dependency lockfile, shell rc file, or runtime code path was modified.
Closes #21829
Related to #17266