Skip to content

feat(deps): add hindsight-client as optional dependency#21818

Merged
alt-glitch merged 2 commits into
mainfrom
feat/hindsight-optional-dep
May 11, 2026
Merged

feat(deps): add hindsight-client as optional dependency#21818
alt-glitch merged 2 commits into
mainfrom
feat/hindsight-optional-dep

Conversation

@alt-glitch

@alt-glitch alt-glitch commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Declares hindsight-client as an optional dependency group [hindsight] in pyproject.toml, allowing build-time inclusion for environments where runtime pip install fails (NixOS sealed venvs, Docker, Kubernetes).

Not included in [all] — memory providers are plugins and should be opted into explicitly. Same pattern should apply to other memory providers (mem0, supermemory, etc.) if they need this treatment.

Install

# pip/uv users
uv sync --extra hindsight
pip install hermes-agent[hindsight]
# Docker/k8s
FROM nousresearch/hermes-agent:latest
RUN pip install hermes-agent[hindsight]
# NixOS (requires #21817 for extraDependencyGroups)
services.hermes-agent.extraDependencyGroups = [ "hindsight" ];

Changes

  • pyproject.toml: Added hindsight = ["hindsight-client>=0.4.22"] to optional dependencies
  • uv.lock: Regenerated to include hindsight-client v0.5.6

Closes #8873

@alt-glitch
feat(deps): add hindsight-client as optional dependency
aa082eb 
Declares hindsight-client as an optional dependency group [hindsight]
in pyproject.toml. This allows build-time inclusion for environments
where runtime pip install is not possible (NixOS sealed venvs, Docker,
Kubernetes).

Not included in [all] — memory providers are plugins and should be
opted into explicitly.

Install via:
  uv sync --extra hindsight
  pip install hermes-agent[hindsight]

NixOS (with extraDependencyGroups):
  services.hermes-agent.extraDependencyGroups = [ "hindsight" ];

Closes #8873
@alt-glitch alt-glitch added comp/plugins Plugin system and bundled plugins tool/memory Memory tool and memory providers area/nix Nix flake, NixOS module, container packaging labels May 8, 2026
@github-actions

github-actions Bot commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔎 Lint report: feat/hindsight-optional-dep vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8157 on HEAD, 8157 on base (➖ 0)

🆕 New issues (3):

Rule Count
invalid-argument-type 3
First entries 
run_agent.py:7160: [invalid-argument-type] invalid-argument-type: Argument to function `build_anthropic_client` is incorrect: Expected `str`, found `str | dict[Unknown, Unknown] | Any | ... omitted 3 union elements`
run_agent.py:13312: [invalid-argument-type] invalid-argument-type: Argument to function `_is_oauth_token` is incorrect: Expected `str`, found `str | dict[Unknown, Unknown] | Any | ... omitted 3 union elements`
run_agent.py:13315: [invalid-argument-type] invalid-argument-type: Argument to function `len` is incorrect: Expected `Sized`, found `(str & ~AlwaysFalsy) | (dict[Unknown, Unknown] & ~AlwaysFalsy) | (Any & ~AlwaysFalsy) | ... omitted 3 union elements`

✅ Fixed issues (3):

Rule Count
invalid-argument-type 3
First entries 
run_agent.py:13315: [invalid-argument-type] invalid-argument-type: Argument to function `len` is incorrect: Expected `Sized`, found `(str & ~AlwaysFalsy) | (dict[Unknown | str, Unknown | str | dict[str, str]] & ~AlwaysFalsy) | (Any & ~AlwaysFalsy) | ... omitted 3 union elements`
run_agent.py:7160: [invalid-argument-type] invalid-argument-type: Argument to function `build_anthropic_client` is incorrect: Expected `str`, found `str | dict[Unknown | str, Unknown | str | dict[str, str]] | Any | ... omitted 3 union elements`
run_agent.py:13312: [invalid-argument-type] invalid-argument-type: Argument to function `_is_oauth_token` is incorrect: Expected `str`, found `str | dict[Unknown | str, Unknown | str | dict[str, str]] | Any | ... omitted 3 union elements`

Unchanged: 4284 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch mentioned this pull request May 8, 2026
Closed
9 tasks
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have dependencies Pull requests that update a dependency file labels May 8, 2026
@alt-glitch

alt-glitch commented May 11, 2026

Copy link
Copy Markdown
Collaborator Author

@jbotwell thank you for approving! apologies for the delay.

@alt-glitch alt-glitch merged commit d992fd9 into main May 11, 2026
14 of 17 checks passed
@alt-glitch alt-glitch deleted the feat/hindsight-optional-dep branch May 11, 2026 06:52
@bot-ted bot-ted mentioned this pull request May 11, 2026
Merged
rmulligan pushed a commit to rmulligan/hermes-agent that referenced this pull request May 11, 2026
@alt-glitch
feat(deps): add hindsight-client as optional dependency (NousResearch…
daa94b7 
…#21818)

Declares hindsight-client as an optional dependency group [hindsight]
in pyproject.toml. This allows build-time inclusion for environments
where runtime pip install is not possible (NixOS sealed venvs, Docker,
Kubernetes).

Not included in [all] — memory providers are plugins and should be
opted into explicitly.

Install via:
  uv sync --extra hindsight
  pip install hermes-agent[hindsight]

NixOS (with extraDependencyGroups):
  services.hermes-agent.extraDependencyGroups = [ "hindsight" ];

Closes NousResearch#8873
JinyuID pushed a commit to JinyuID/hermes-agent that referenced this pull request May 11, 2026
@alt-glitch
feat(deps): add hindsight-client as optional dependency (NousResearch…
8e8cb3c 
…#21818)

Declares hindsight-client as an optional dependency group [hindsight]
in pyproject.toml. This allows build-time inclusion for environments
where runtime pip install is not possible (NixOS sealed venvs, Docker,
Kubernetes).

Not included in [all] — memory providers are plugins and should be
opted into explicitly.

Install via:
  uv sync --extra hindsight
  pip install hermes-agent[hindsight]

NixOS (with extraDependencyGroups):
  services.hermes-agent.extraDependencyGroups = [ "hindsight" ];

Closes NousResearch#8873
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
@alt-glitch
feat(deps): add hindsight-client as optional dependency (NousResearch…
a988ce3 
…#21818)

Declares hindsight-client as an optional dependency group [hindsight]
in pyproject.toml. This allows build-time inclusion for environments
where runtime pip install is not possible (NixOS sealed venvs, Docker,
Kubernetes).

Not included in [all] — memory providers are plugins and should be
opted into explicitly.

Install via:
  uv sync --extra hindsight
  pip install hermes-agent[hindsight]

NixOS (with extraDependencyGroups):
  services.hermes-agent.extraDependencyGroups = [ "hindsight" ];

Closes NousResearch#8873
jsboige pushed a commit to jsboige/hermes-agent that referenced this pull request May 14, 2026
@alt-glitch
feat(deps): add hindsight-client as optional dependency (NousResearch…
474cc91 
…#21818)

Declares hindsight-client as an optional dependency group [hindsight]
in pyproject.toml. This allows build-time inclusion for environments
where runtime pip install is not possible (NixOS sealed venvs, Docker,
Kubernetes).

Not included in [all] — memory providers are plugins and should be
opted into explicitly.

Install via:
  uv sync --extra hindsight
  pip install hermes-agent[hindsight]

NixOS (with extraDependencyGroups):
  services.hermes-agent.extraDependencyGroups = [ "hindsight" ];

Closes NousResearch#8873
@github-actions github-actions Bot mentioned this pull request May 17, 2026
Merged
AlexFoxD pushed a commit to AlexFoxD/hermes-agent that referenced this pull request May 21, 2026
@alt-glitch @AlexFoxD
feat(deps): add hindsight-client as optional dependency (NousResearch…
b5f0676 
…#21818)

Declares hindsight-client as an optional dependency group [hindsight]
in pyproject.toml. This allows build-time inclusion for environments
where runtime pip install is not possible (NixOS sealed venvs, Docker,
Kubernetes).

Not included in [all] — memory providers are plugins and should be
opted into explicitly.

Install via:
  uv sync --extra hindsight
  pip install hermes-agent[hindsight]

NixOS (with extraDependencyGroups):
  services.hermes-agent.extraDependencyGroups = [ "hindsight" ];

Closes NousResearch#8873
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
@alt-glitch
feat(deps): add hindsight-client as optional dependency (NousResearch…
eb80fc7 
…#21818)

Declares hindsight-client as an optional dependency group [hindsight]
in pyproject.toml. This allows build-time inclusion for environments
where runtime pip install is not possible (NixOS sealed venvs, Docker,
Kubernetes).

Not included in [all] — memory providers are plugins and should be
opted into explicitly.

Install via:
  uv sync --extra hindsight
  pip install hermes-agent[hindsight]

NixOS (with extraDependencyGroups):
  services.hermes-agent.extraDependencyGroups = [ "hindsight" ];

Closes NousResearch#8873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jbotwell jbotwell jbotwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/nix Nix flake, NixOS module, container packaging comp/plugins Plugin system and bundled plugins dependencies Pull requests that update a dependency file P3 Low — cosmetic, nice to have tool/memory Memory tool and memory providers type/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Setup]: Hindsight-client required to use hindsight as memory provider, but can't be installed with non-container nixos config

2 participants

@alt-glitch @jbotwell