fix(doctor): retry DashScope China endpoint on 401 (salvage #19191)#21248
Merged
Conversation
Contributor
🔎 Lint report:
|
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19191 via salvage. Fixes #18904.
Summary
China-based users have DashScope credentials that only work against
dashscope.aliyuncs.com/compatible-mode/v1, not the international endpoint. The doctor probe only tried international and reported 401 as a hard failure. Add a single fallback retry against the China endpoint when international 401s and no explicitDASHSCOPE_BASE_URLoverride is set.Validation
scripts/run_tests.sh tests/hermes_cli/test_doctor.py -k dashscope→ 1 passed (new regression).Original author: @LeonSGP43.