Skip to content

fix(doctor): retry DashScope China endpoint#19191

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/dashscope-doctor-china-fallback-18904
Closed

fix(doctor): retry DashScope China endpoint#19191
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/dashscope-doctor-china-fallback-18904

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Fixes #18904

Summary

  • Retry the China DashScope compatible-mode /models endpoint when the default international DashScope doctor probe returns 401.
  • Keep explicit DASHSCOPE_BASE_URL behavior unchanged.
  • Add a mocked doctor regression covering an international 401 followed by a China endpoint success.

Verification

  • scripts/run_tests.sh tests/hermes_cli/test_doctor.py::test_run_doctor_dashscope_retries_china_endpoint_after_intl_unauthorized tests/hermes_cli/test_doctor.py::test_run_doctor_kimi_cn_env_is_detected_and_probe_is_null_safe tests/hermes_cli/test_doctor.py::test_run_doctor_opencode_go_skips_invalid_models_probe
    • 4 passed, 4 warnings

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard provider/qwen Qwen / Alibaba Cloud (OAuth) labels May 3, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing fix for #18904 — see also #18952 and #18910 which address the same DashScope China endpoint fallback.

1 similar comment
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing fix for #18904 — see also #18952 and #18910 which address the same DashScope China endpoint fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists provider/qwen Qwen / Alibaba Cloud (OAuth) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: hermes doctor reports valid China DashScope API key as invalid

2 participants