Skip to content

fix(tools,cli): normalise MCP schemas + expand session list columns#2102

Merged
teknium1 merged 2 commits into
mainfrom
hermes/hermes-6757a563
Mar 20, 2026
Merged

fix(tools,cli): normalise MCP schemas + expand session list columns#2102
teknium1 merged 2 commits into
mainfrom
hermes/hermes-6757a563

Conversation

@teknium1

@teknium1 teknium1 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Two salvaged bug fixes on current main.

1. Normalise MCP object schemas without properties (PR #2095 by @sammcf)

Normalises MCP tool input schemas that declare {"type": "object"} without a properties field before forwarding them to the LLM tool-calling API. Fixes a 400 Bad Request from OpenAI when an MCP server exposes a bare object schema (e.g. Crawl4AI's ask tool).

  • Added _normalize_mcp_input_schema() in tools/mcp_tool.py
  • Applied to both MCP tool discovery and the sampling callback
  • Regression tests for both code paths

Cherry-picked from #2095 with authorship preserved.

2. Expand session list columns for full ID visibility (PR #2085 by @Nebula037, fixes #2068)

hermes sessions list was truncating session IDs to 20 chars ([:20]), cutting off the last 2-4 characters. This made it impossible to copy the correct ID for --resume.

  • Removed [:20] truncation — full IDs now shown
  • Widened title column from 20→30 chars
  • Adjusted header/separator widths

Based on #2085 with a correction: the original PR accidentally replaced the no-titles layout (Preview/Src header) with a duplicate of the has-titles layout (Title/Preview header), misaligning columns when sessions have no titles.

Test plan

python -m pytest tests/ -n0 -q  # 5524 passed

hermes and others added 2 commits March 19, 2026 16:23
Show complete session IDs in 'hermes sessions list' instead of
truncating to 20 characters. Widens title column from 20→30 chars
and adjusts header widths accordingly.

Fixes #2068. Based on PR #2085 by @Nebula037 with a correction
to preserve the no-titles layout (the original PR accidentally
replaced the Preview/Src header with a duplicate Title/Preview header).
@teknium1 teknium1 changed the title fix(tools): normalise MCP object schemas without properties fix(tools,cli): normalise MCP schemas + expand session list columns Mar 20, 2026
@teknium1 teknium1 merged commit d808179 into main Mar 20, 2026
1 check failed
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
…6757a563

fix(tools,cli): normalise MCP schemas + expand session list columns
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
…6757a563

fix(tools,cli): normalise MCP schemas + expand session list columns
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
…6757a563

fix(tools,cli): normalise MCP schemas + expand session list columns
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
…6757a563

fix(tools,cli): normalise MCP schemas + expand session list columns
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
…6757a563

fix(tools,cli): normalise MCP schemas + expand session list columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Session ID Truncated in hermes sessions list

1 participant