feat(i18n): add Korean (ko) locale#20630
Closed
RyanRana wants to merge 1 commit into
Closed
Conversation
Adds Korean as the 9th supported UI locale for static user-facing messages (CLI approval prompt, gateway slash-command replies). Mirrors the Turkish (#20474) and Ukrainian (#20467) PRs. - locales/ko.yaml: 18-key catalog (Korean translations of en.yaml) - agent/i18n.py: ko in SUPPORTED_LANGUAGES, aliases korean / 한국어 / ko-kr / kr - hermes_cli/config.py + locales/en.yaml: supported-language comments - website/docs/user-guide/configuration.md: docs updated - tests/agent/test_i18n.py: alias + round-trip assertions Closes the UI-locale half of #18126 / #18124 (Korean translation requests). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
Duplicate of #20297 — same feature (Korean static message locale). Competing PRs for the same i18n addition. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Korean (
ko) as the 9th supported UI locale, following the exact pattern offeat(i18n): add Turkish (tr) locale(#20474) andfeat(i18n): add Ukrainian locale(#20467).Translates the small set of static user-facing messages — CLI approval prompts and a handful of gateway slash-command replies. Agent-generated output, log lines, error tracebacks, and tool outputs continue to stay in English by design.
Changes
locales/ko.yaml— 18-key catalog (Korean translations of every key inlocales/en.yaml)agent/i18n.py—"ko"added toSUPPORTED_LANGUAGES; aliaseskorean,한국어,ko-kr,kradded to_LANGUAGE_ALIASEShermes_cli/config.py— supported-language comment updatedlocales/en.yaml— header note updated to listkowebsite/docs/user-guide/configuration.md— both docs lines updatedtests/agent/test_i18n.py— alias assertions + at("approval.denied", lang="ko")round-trip assertionCommunity signal
Closes the UI-locale half of two long-standing open issues requesting Korean support: #18126 and #18124. The issues focus on docs translation (larger scope); a UI locale catalog is the surgical first step.
Test plan
pytest tests/agent/test_i18n.py— all 29 tests pass locallytest_catalog_keys_match_english) automatically coverskovia parametrize overSUPPORTED_LANGUAGEStest_catalog_placeholders_match_english) confirms{description},{count},{error}tokens preservedHERMES_LANGUAGE=ko hermesshows the Korean approval prompt🤖 Generated with Claude Code