fix(acp): preserve assistant reasoning metadata in session persistence (salvage #13575)#20296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages @Aslaaen's PR #13575 onto current main.
What it does
ACP
save_session()calleddb.append_message()without thereasoning/reasoning_details/codex_reasoning_itemskwargs, so those fields were dropped on every session save and resumed sessions lost their thinking/reasoning context.Changes
acp_adapter/session.py— pass the three reasoning fields toappend_message.tests/acp/test_session.py— round-trip regression test.scripts/release.py— AUTHOR_MAP entry for Aslaaen.Relationship to #20279
Salvage PR #20279 (for #13675) rewrites save_session to use
replace_messagesinstead ofclear_messages+append_messageloop. Once #20279 lands,replace_messagesalready handles these reasoning fields and this fix becomes a no-op. Both PRs are safe to land in either order.Validation
tests/acp/test_session.py— 40 passed locally.Closes #13575 via salvage.