fix(acp): preserve assistant reasoning metadata in session persistence#13575
Closed
Aslaaen wants to merge 1 commit into
Closed
fix(acp): preserve assistant reasoning metadata in session persistence#13575Aslaaen wants to merge 1 commit into
Aslaaen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACP session persistence was dropping assistant reasoning metadata during save/restore.
This change forwards assistant
reasoning,reasoning_details, andcodex_reasoning_itemsintoSessionDB.append_message()so restored ACPsessions retain the same assistant context they had before persistence.
Why this is a bug
hermes_state.SessionDBalready supports storing and restoring these fields,but
acp_adapter.session.SessionManager._persist()only wrote the basicmessage fields. As a result, ACP session restore silently degraded assistant
history by removing reasoning-related metadata.
That created an inconsistent round-trip:
Changes
reasoningreasoning_detailscodex_reasoning_itemsTests
Ran:
uv run --with pytest --with pytest-xdist pytest tests/acp/test_session.py -q -n 4Result:
31 passed