Skip to content

fix(gateway): update inaccurate platform notes for Discord and Slack#2026

Closed
mettin4 wants to merge 4 commits into
NousResearch:mainfrom
mettin4:fix/platform-notes-discord-slack
Closed

fix(gateway): update inaccurate platform notes for Discord and Slack#2026
mettin4 wants to merge 4 commits into
NousResearch:mainfrom
mettin4:fix/platform-notes-discord-slack

Conversation

@mettin4

@mettin4 mettin4 commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Platform notes incorrectly stated the agent has no API access to Discord/Slack. The agent can use terminal + curl with the Bot token to access these APIs.

Closes #2020

What does this PR do?

Platform notes in gateway/session.py incorrectly told the agent it has no API access to Discord and Slack. The agent can actually use terminal + curl with the Bot token from config to interact with these APIs. This fix updates the hardcoded messages to reflect the actual capabilities.

Related Issue

Fixes #2020

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • gateway/session.py: Updated inaccurate platform notes for Discord and Slack

How to Test

  1. Run Hermes Agent with Discord or Slack gateway
  2. Ask the agent to perform a Discord/Slack API action
  3. Verify the agent no longer refuses due to incorrect platform notes

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

@mettin4

mettin4 commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The test_delegate.py failures are pre-existing and unrelated to this PR
They stem from a NameError in delegate_tool.py:235 that exists on main branch.

@teknium1

teknium1 commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Closing — the replacement strings are truncated mid-word ("Slack-specifi") so this would inject broken text into the system prompt. The test also has a duplicate condition ("do not have access" or "do not have access").

Beyond the bugs, encouraging the agent to use curl with bot tokens from config to access Discord/Slack APIs is a security concern — we don't want the agent extracting and wielding auth tokens directly. The current conservative notes ("you cannot do these actions") are intentional. If we want the agent to interact with platform APIs, the right approach is dedicated check_fn-gated tools with proper scoping, not raw curl with tokens.

@teknium1 teknium1 closed this Mar 30, 2026
@daikeren daikeren mentioned this pull request Apr 9, 2026
Open
1 task
lawyerwenhan pushed a commit to lawyerwenhan/hermes-agent that referenced this pull request Apr 18, 2026
@wenhanshi
cron: audit log rotation + health check report NousResearch#2026-04-16
bad8310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: make platform notes configurable instead of hardcoded limitations

3 participants

@mettin4 @teknium1 @Rafa-Ross