fix(cron): honor per-job profile during scheduler runs#19958
Closed
Michaelyklam wants to merge 2 commits into
Closed
fix(cron): honor per-job profile during scheduler runs#19958Michaelyklam wants to merge 2 commits into
Michaelyklam wants to merge 2 commits into
Conversation
Collaborator
Author
|
Resolved the merge conflict against current Follow-up commit: ce29663 Verification:
Current PR status: mergeable; no GitHub checks are configured on the PR at the moment. |
This was referenced May 13, 2026
19 tasks
daimon-nous Bot
pushed a commit
that referenced
this pull request
May 18, 2026
Avoids a brief window where other threads see an empty os.environ during profile job teardown. Idea from PR #19958.
daimon-nous Bot
pushed a commit
that referenced
this pull request
May 18, 2026
Instead of raising FileNotFoundError (which silently bricks the job), log a warning and fall back to the scheduler default home. Validates at create/update time still catches typos. Idea from PR #19958.
Contributor
|
Superseded by PR #28124 which merged #25917's more complete implementation (ContextVar isolation, CLI --profile, tool schema, subprocess bridging). Your delta-restore and graceful-fallback ideas from this PR were incorporated as follow-up commits — credited in the PR description. Thank you @Michaelyklam! |
Lillard01
pushed a commit
to Lillard01/hermes-agent
that referenced
this pull request
May 21, 2026
Avoids a brief window where other threads see an empty os.environ during profile job teardown. Idea from PR NousResearch#19958.
Lillard01
pushed a commit
to Lillard01/hermes-agent
that referenced
this pull request
May 21, 2026
Instead of raising FileNotFoundError (which silently bricks the job), log a warning and fall back to the scheduler default home. Validates at create/update time still catches typos. Idea from PR NousResearch#19958.
Mucky010
pushed a commit
to Mucky010/hermes-agent
that referenced
this pull request
May 24, 2026
Avoids a brief window where other threads see an empty os.environ during profile job teardown. Idea from PR NousResearch#19958.
Mucky010
pushed a commit
to Mucky010/hermes-agent
that referenced
this pull request
May 24, 2026
Instead of raising FileNotFoundError (which silently bricks the job), log a warning and fall back to the scheduler default home. Validates at create/update time still catches typos. Idea from PR NousResearch#19958.
1 task
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
Avoids a brief window where other threads see an empty os.environ during profile job teardown. Idea from PR NousResearch#19958.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
Instead of raising FileNotFoundError (which silently bricks the job), log a warning and fall back to the scheduler default home. Validates at create/update time still catches typos. Idea from PR NousResearch#19958.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profilevalues, preserving missing/blank profile as legacy server-default behavior.HERMES_HOME,.env,config.yaml, SOUL/context identity, and profile env markers, while restoring process env afterward.Related
Test Plan
.envinstead of the selected profile.env, and missing stored profiles did not warn.python -m pytest tests/cron/test_scheduler_profiles.py -q -o 'addopts='TMP_HOME=$(mktemp -d) && HERMES_HOME="$TMP_HOME" python -m pytest tests/cron/test_scheduler.py tests/cron/test_scheduler_profiles.py -q -o 'addopts='tests/cron/test_cron_script.py::TestBuildJobPromptWithScript::test_script_empty_output_notedexpects a "no output" prompt but_build_job_prompt()returnsNonefor empty script output.