Skip to content

fix(cli): use proper singular/plural in doctor and claw messages#19830

Merged
austinpickett merged 3 commits into
mainfrom
austin/fix/pluralization
May 8, 2026
Merged

fix(cli): use proper singular/plural in doctor and claw messages#19830
austinpickett merged 3 commits into
mainfrom
austin/fix/pluralization

Conversation

@austinpickett

Copy link
Copy Markdown
Collaborator

What does this PR do?

Replaces awkward parenthetical plurals vulnerability(ies) and directory(ies) with grammatically correct wording based on the count: 1 vulnerability / N vulnerabilities, 1 directory / N directories. Parenthetical (ies) does not read well in terminal output; branching on n == 1 matches real English without new dependencies.

Related Issue

Fixes # (none — polish / UX copy; link an issue if you filed one)

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

(You could argue “refactor” instead of “bug fix”; either is fine.)

Changes Made

  • hermes_cli/doctor.py — npm audit summary: use vulnerability / vulnerabilities from total and moderate counts instead of vulnerability(ies).
  • hermes_cli/claw.py — OpenClaw migration dry-run and cleanup summaries: use directory / directories from len(dirs_to_check) and total_archived instead of directory(ies).

How to Test

  1. Run hermes doctor (or the doctor path that runs npm audit) in a tree where Browser tools / WhatsApp bridge node_modules exist and audit reports 0, 1, or multiple vulnerabilities; confirm messages use singular/plural correctly.
  2. Run the OpenClaw migration flow with --dry-run and with real cleanup when multiple vs one directory apply; confirm the printed counts match singular/plural wording.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

(omit or delete — not applicable)

Screenshots / Logs

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels May 4, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@austinpickett

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

Co-authored-by: austinpickett <260188+austinpickett@users.noreply.github.com>

Copilot AI commented May 7, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved and pushed. I merged latest origin/main, fixed the nix/tui.nix conflict, and finalized the merge commit 901eccc.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • models.dev
    • Triggering command: /home/REDACTED/work/hermes-agent/hermes-agent/.venv/bin/python /home/REDACTED/work/hermes-agent/hermes-agent/.venv/bin/python -u -c import sys;exec(eval(sys.stdin.readline())) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@austinpickett austinpickett merged commit a313186 into main May 8, 2026
6 checks passed
@austinpickett austinpickett deleted the austin/fix/pluralization branch May 8, 2026 12:22
JinyuID pushed a commit to JinyuID/hermes-agent that referenced this pull request May 11, 2026
…uralization

fix(cli): use proper singular/plural in doctor and claw messages
jsboige pushed a commit to jsboige/hermes-agent that referenced this pull request May 14, 2026
…uralization

fix(cli): use proper singular/plural in doctor and claw messages
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
…uralization

fix(cli): use proper singular/plural in doctor and claw messages
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
…uralization

fix(cli): use proper singular/plural in doctor and claw messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants