fix(cli): use proper singular/plural in doctor and claw messages#19830
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: austinpickett <260188+austinpickett@users.noreply.github.com>
Contributor
Resolved and pushed. I merged latest Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
JinyuID
pushed a commit
to JinyuID/hermes-agent
that referenced
this pull request
May 11, 2026
…uralization fix(cli): use proper singular/plural in doctor and claw messages
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
…uralization fix(cli): use proper singular/plural in doctor and claw messages
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…uralization fix(cli): use proper singular/plural in doctor and claw messages
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…uralization fix(cli): use proper singular/plural in doctor and claw messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces awkward parenthetical plurals
vulnerability(ies)anddirectory(ies)with grammatically correct wording based on the count: 1 vulnerability / N vulnerabilities, 1 directory / N directories. Parenthetical(ies)does not read well in terminal output; branching onn == 1matches real English without new dependencies.Related Issue
Fixes # (none — polish / UX copy; link an issue if you filed one)
Type of Change
(You could argue “refactor” instead of “bug fix”; either is fine.)
Changes Made
hermes_cli/doctor.py— npm audit summary: usevulnerability/vulnerabilitiesfromtotalandmoderatecounts instead ofvulnerability(ies).hermes_cli/claw.py— OpenClaw migration dry-run and cleanup summaries: usedirectory/directoriesfromlen(dirs_to_check)andtotal_archivedinstead ofdirectory(ies).How to Test
hermes doctor(or the doctor path that runs npm audit) in a tree where Browser tools / WhatsApp bridgenode_modulesexist and audit reports 0, 1, or multiple vulnerabilities; confirm messages use singular/plural correctly.--dry-runand with real cleanup when multiple vs one directory apply; confirm the printed counts match singular/plural wording.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
(omit or delete — not applicable)
Screenshots / Logs