Skip to content

revert: auto-subscribe gateway chat on tool-driven kanban_create (#19718)#19721

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-6c8ebd95
May 4, 2026
Merged

revert: auto-subscribe gateway chat on tool-driven kanban_create (#19718)#19721
teknium1 merged 1 commit into
mainfrom
hermes/hermes-6c8ebd95

Conversation

@teknium1

@teknium1 teknium1 commented May 4, 2026

Copy link
Copy Markdown
Contributor

Reverts #19718 (ff3d277).

After merging, Teknium reviewed the behavior and decided implicit auto-subscribe on tool-driven kanban_create is not wanted. Subscription should stay explicit — via the existing hermes kanban notify-subscribe CLI or a future dashboard/GUI opt-in flow.

No migration needed — kanban_notify_subs rows created by the feature (during the ~2h it was merged) are harmless; they'll just deliver one extra notification per task that was created in that window. Nothing to clean up.

)

Reverts ff3d277. Teknium reviewed the merged PR and decided this
behavior isn't wanted — tool-driven kanban_create should not mirror
the slash-command path's auto-subscribe. Orchestrators that want
their originating chat notified can call kanban_notify-subscribe
explicitly; we're not going to make it implicit.
@teknium1 teknium1 merged commit 3fb3552 into main May 4, 2026
4 checks passed
@teknium1 teknium1 deleted the hermes/hermes-6c8ebd95 branch May 4, 2026 12:04
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have comp/tools Tool registry, model_tools, toolsets labels May 4, 2026
nickdlkk pushed a commit to nickdlkk/hermes-agent that referenced this pull request May 11, 2026
…sResearch#19718) (NousResearch#19721)

Reverts ff3d277. Teknium reviewed the merged PR and decided this
behavior isn't wanted — tool-driven kanban_create should not mirror
the slash-command path's auto-subscribe. Orchestrators that want
their originating chat notified can call kanban_notify-subscribe
explicitly; we're not going to make it implicit.
rmulligan pushed a commit to rmulligan/hermes-agent that referenced this pull request May 11, 2026
…sResearch#19718) (NousResearch#19721)

Reverts ff3d277. Teknium reviewed the merged PR and decided this
behavior isn't wanted — tool-driven kanban_create should not mirror
the slash-command path's auto-subscribe. Orchestrators that want
their originating chat notified can call kanban_notify-subscribe
explicitly; we're not going to make it implicit.
jsboige pushed a commit to jsboige/hermes-agent that referenced this pull request May 14, 2026
…sResearch#19718) (NousResearch#19721)

Reverts b48e01e. Teknium reviewed the merged PR and decided this
behavior isn't wanted — tool-driven kanban_create should not mirror
the slash-command path's auto-subscribe. Orchestrators that want
their originating chat notified can call kanban_notify-subscribe
explicitly; we're not going to make it implicit.
dannyJ848 pushed a commit to dannyJ848/hermes-agent that referenced this pull request May 17, 2026
…sResearch#19718) (NousResearch#19721)

Reverts 67be580. Teknium reviewed the merged PR and decided this
behavior isn't wanted — tool-driven kanban_create should not mirror
the slash-command path's auto-subscribe. Orchestrators that want
their originating chat notified can call kanban_notify-subscribe
explicitly; we're not going to make it implicit.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
…sResearch#19718) (NousResearch#19721)

Reverts ff3d277. Teknium reviewed the merged PR and decided this
behavior isn't wanted — tool-driven kanban_create should not mirror
the slash-command path's auto-subscribe. Orchestrators that want
their originating chat notified can call kanban_notify-subscribe
explicitly; we're not going to make it implicit.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
…sResearch#19718) (NousResearch#19721)

Reverts 7017e27. Teknium reviewed the merged PR and decided this
behavior isn't wanted — tool-driven kanban_create should not mirror
the slash-command path's auto-subscribe. Orchestrators that want
their originating chat notified can call kanban_notify-subscribe
explicitly; we're not going to make it implicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants