Skip to content

fix(honcho): hide session banner when not explicitly configured#1960

Closed
erosika wants to merge 1 commit into
NousResearch:mainfrom
erosika:fix/honcho-banner-gate
Closed

fix(honcho): hide session banner when not explicitly configured#1960
erosika wants to merge 1 commit into
NousResearch:mainfrom
erosika:fix/honcho-banner-gate

Conversation

@erosika

@erosika erosika commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The Honcho session: <name> line was showing on CLI startup for users who never ran hermes honcho setup but had HONCHO_API_KEY in their env or a shared ~/.honcho/config.json from another tool
  • Now requires explicit opt-in before displaying: a hosts.hermes block exists (from setup) OR enabled: true is explicitly set at root or host level

Test plan

  • Verify banner hidden when no hosts.hermes block exists in ~/.honcho/config.json
  • Verify banner hidden when only HONCHO_API_KEY env var is set (no config file)
  • Verify banner still shows after hermes honcho setup

Related meta issue: #2210

@erosika erosika marked this pull request as draft March 18, 2026 17:01
@erosika erosika force-pushed the fix/honcho-banner-gate branch from d58cc9d to 201cbca Compare March 18, 2026 17:03
@erosika erosika marked this pull request as ready for review March 18, 2026 18:35
@erosika erosika force-pushed the fix/honcho-banner-gate branch 3 times, most recently from b1197f4 to fed9331 Compare March 19, 2026 20:05
teknium1 added a commit that referenced this pull request Mar 21, 2026
Add explicitly_configured field to HonchoClientConfig — set when the
config has a hosts.hermes block or explicit enabled flag, vs auto-enabled
from a stray HONCHO_API_KEY env var.  Banner only shows when this is true.

Based on #1960 by @erosika, reimplemented without duplicating config parsing.
The Honcho session line appeared on CLI startup for users who never
ran `hermes honcho setup` but had HONCHO_API_KEY in their env or a
shared ~/.honcho/config.json from another tool. The auto-enable logic
(enabled=bool(api_key)) meant any floating API key triggered the
banner.

Now require explicit opt-in before showing the indicator:
- A hosts.hermes block exists (from `hermes honcho setup`), OR
- `enabled: true` is explicitly set at root or host level

Auto-enable from API key presence alone no longer triggers the banner.
@erosika erosika force-pushed the fix/honcho-banner-gate branch from fed9331 to ea2394f Compare March 21, 2026 23:05
@teknium1

Copy link
Copy Markdown
Contributor

Fixed in #2343 via explicitly_configured field on HonchoClientConfig. Thanks @erosika!

@teknium1 teknium1 closed this Mar 21, 2026
outsourc-e pushed a commit to outsourc-e/hermes-agent that referenced this pull request Mar 26, 2026
Add explicitly_configured field to HonchoClientConfig — set when the
config has a hosts.hermes block or explicit enabled flag, vs auto-enabled
from a stray HONCHO_API_KEY env var.  Banner only shows when this is true.

Based on NousResearch#1960 by @erosika, reimplemented without duplicating config parsing.
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
Add explicitly_configured field to HonchoClientConfig — set when the
config has a hosts.hermes block or explicit enabled flag, vs auto-enabled
from a stray HONCHO_API_KEY env var.  Banner only shows when this is true.

Based on NousResearch#1960 by @erosika, reimplemented without duplicating config parsing.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
Add explicitly_configured field to HonchoClientConfig — set when the
config has a hosts.hermes block or explicit enabled flag, vs auto-enabled
from a stray HONCHO_API_KEY env var.  Banner only shows when this is true.

Based on NousResearch#1960 by @erosika, reimplemented without duplicating config parsing.
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
Add explicitly_configured field to HonchoClientConfig — set when the
config has a hosts.hermes block or explicit enabled flag, vs auto-enabled
from a stray HONCHO_API_KEY env var.  Banner only shows when this is true.

Based on NousResearch#1960 by @erosika, reimplemented without duplicating config parsing.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
Add explicitly_configured field to HonchoClientConfig — set when the
config has a hosts.hermes block or explicit enabled flag, vs auto-enabled
from a stray HONCHO_API_KEY env var.  Banner only shows when this is true.

Based on NousResearch#1960 by @erosika, reimplemented without duplicating config parsing.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
Add explicitly_configured field to HonchoClientConfig — set when the
config has a hosts.hermes block or explicit enabled flag, vs auto-enabled
from a stray HONCHO_API_KEY env var.  Banner only shows when this is true.

Based on NousResearch#1960 by @erosika, reimplemented without duplicating config parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants