fix(kanban): enable kanban tools for profiles with kanban in toolsets config#18991
Closed
shellybotmoyer wants to merge 1 commit into
Closed
fix(kanban): enable kanban tools for profiles with kanban in toolsets config#18991shellybotmoyer wants to merge 1 commit into
shellybotmoyer wants to merge 1 commit into
Conversation
… config _check_kanban_mode() now also returns True when the current profile has kanban in its toolsets config, not just when HERMES_KANBAN_TASK is set. This allows orchestrator profiles to use kanban tools without being dispatched workers. Fixes NousResearch#18968
Collaborator
1 similar comment
Collaborator
This was referenced May 4, 2026
Contributor
|
Closing as duplicate of #18970 (and #18971, also yours). Same fix shape. Merged #19606 which used @pdonizete's commit — they submitted first and authored the underlying issue. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
_check_kanban_mode()now also returnsTruewhen the current profile haskanbanin itstoolsetsconfig, not just whenHERMES_KANBAN_TASKis set in the environment.Problem
The
_check_kanban_mode()gating function only checkedos.environ.get("HERMES_KANBAN_TASK"), which is only set by the kanban dispatcher when spawning a worker process. This meant:kanbanin theirtoolsetsconfig saw zero kanban toolsFix
Extended
_check_kanban_mode()to also checkload_config()for"kanban"in the current profile'stoolsetslist. Uses the same mtime-cachedload_config()that othercheck_fnfunctions use, so this is cheap on repeated calls.The existing env-var check is preserved as the first (faster) path, so there's no performance regression for dispatched workers.
Testing
HERMES_KANBAN_TASKset → still get all kanban tools (env var check runs first)toolsets: [kanban, ...]→ now get all kanban toolskanbanin toolsets and no env var → still see zero kanban toolsFixes #18968