fix(tools): allow orchestrator profiles to see kanban tools via toolsets config#18971
Closed
shellybotmoyer wants to merge 1 commit into
Closed
fix(tools): allow orchestrator profiles to see kanban tools via toolsets config#18971shellybotmoyer wants to merge 1 commit into
shellybotmoyer wants to merge 1 commit into
Conversation
…ets config Extends _check_kanban_mode to also check if "kanban" is in the current profile toolsets config, not just HERMES_KANBAN_TASK env var. Orchestrator profiles that route work via Kanban were invisible to the kanban tool check because only workers get the env var. Fixes NousResearch#18968.
This was referenced May 4, 2026
Contributor
|
Closing as duplicate of #18970. Same fix shape ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
_check_kanban_mode()intools/kanban_tools.pyto also returnTruewhen the active profile haskanbanin itstoolsetsconfig — not only whenHERMES_KANBAN_TASKenv var is set.Problem
Orchestrator profiles (e.g., a techlead that routes work via Kanban) cannot see any kanban tools (
kanban_create,kanban_link, etc.) even when they havekanbanexplicitly listed in theirtoolsetsconfig. This is because_check_kanban_mode()only checks for theHERMES_KANBAN_TASKenv var, which is only set by the kanban dispatcher when spawning a worker process.The orchestrator then hallucinates task creation because its SOUL.md instructs it to use kanban tools that don't exist in its schema.
Fix
Add a second path to
_check_kanban_mode()that checks the current config forkanbanintoolsets. Uses the existingload_config()which has mtime-based caching, so this adds negligible overhead. The check_fn results are further TTL-cached (~30s) by the tools registry.Workers continue to work via the
HERMES_KANBAN_TASKenv var (no change). Orchestrators now get visibility via theirtoolsetsconfig.Fixes #18968
Testing
kanbanintoolsetsnow see all 7 kanban toolskanbanintoolsetscontinue to see zero kanban tools