fix(gateway): reload .env on /restart so new env keys are picked up#18582
Open
gulivan wants to merge 1 commit into
Open
fix(gateway): reload .env on /restart so new env keys are picked up#18582gulivan wants to merge 1 commit into
gulivan wants to merge 1 commit into
Conversation
Moves load_hermes_dotenv() from module import time to Gateway.start() so that /restart re-evaluates .env contents. Also invalidates the check_fn cache so tool availability (e.g. OLLAMA_API_KEY) is recalculated. Previously .env was loaded once when the gateway Python process started; adding a key later required a full shell-level restart.
Cyrene963
pushed a commit
to Cyrene963/hermes-agent
that referenced
this pull request
May 3, 2026
Community PRs applied: - NousResearch#18596: Enable secret redaction by default (SECURITY) - NousResearch#18650: Sanitize malformed tool messages + auto-recover on API 400 - NousResearch#18607: Emergency compression before max_iterations exhaustion - NousResearch#18603: Compression fallback to main model on 413 rate limit - NousResearch#18638: Pass threshold_percent on model switch - NousResearch#18663: Strip extra_content from tool_calls for strict APIs - NousResearch#18618: Forward explicit_api_key to OpenRouter - NousResearch#18632: Show cache tokens in /insights breakdown - NousResearch#18614: Add idempotency guard for patch duplicate loops - NousResearch#18600: Raise ValueError when HERMES_HOME unset in profile mode - NousResearch#18616: Allow ZWJ emoji in context files - NousResearch#18582: Reload .env on /restart - NousResearch#18547: Stabilize system prompt prefix for KV cache reuse - NousResearch#18692: Strip FTS5 operators from session search truncation terms Fix: Add order_by_last_active=True to list_sessions_rich call (pre-existing commit 142b4bf code sync)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After editing
~/.hermes/.env(e.g. addingOLLAMA_API_KEY) and running/restart, the Gateway process does not see the new environment variables. Consequently, tools whosecheck_fndepends on env vars (such asollama_web_search) remain hidden.Root cause
gateway/run.pyloads.envonce at import time (lines ~255-260). On/restartthe Python module is often cached/reimported, soload_hermes_dotenv()is skipped and stale / missing env values persist. In addition,registry.pycachescheck_fnresults, so even if env changes later the tool definitions are not recalculated.Fix
load_hermes_dotenv()from module level intoGateway.start()so it runs on every gateway start (including restarts).invalidate_check_fn_cache()immediately after loading env, forcing tools to re-evaluate availability with fresh env values._env_pathvariable because the agents' own credential reload logic (~line 11956) references it.Files changed
gateway/run.pyNo breaking changes.