fix: resolve 7 identified issues [automated]#18337
Open
Sldark23 wants to merge 7 commits into
Open
Conversation
added 7 commits
May 1, 2026 10:20
Collaborator
|
Similar automated omnibus PR pattern as #18270. Verify no file conflicts between the two. |
Collaborator
|
Similar automated omnibus PR pattern as #18270. |
This was referenced May 1, 2026
Tranquil-Flow
added a commit
to Tranquil-Flow/hermes-agent
that referenced
this pull request
May 25, 2026
migrate_full_providers() in openclaw_to_hermes.py guarded the "already exists" path with `not self.overwrite`, but on the overwrite branch it fell through to `custom_providers.append(entry)` instead of replacing the existing entry. Re-running `hermes claw migrate --overwrite` produced two entries with the same name (NousResearch#18097, NousResearch#2). Track the existing entry's index, replace it in place when overwrite is set, append only when no entry exists. Behavior without --overwrite is unchanged: still records a conflict and skips. Fixes the second of three sub-bugs in NousResearch#18097. The WhatsApp config gap (sub-bug 1) is addressed by another open PR (NousResearch#18337). The stale gateway PID report (sub-bug 3) needs more diagnostic info from the reporter to confirm a reproducible code path. Refs NousResearch#18097
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This automated PR resolves 7 open issues in
NousResearch/hermes-agent, prioritizing bug fixes and security hardening.Issues resolved
[Bug]: Background process updates can leak into the wrong Slack thread #18101 – Background process updates could leak into the wrong Slack thread
[Bug]: [Email] IMAP fetch error: 'int' object has no attribute 'decode' #18106 – Email IMAP fetch error:
'int' object has no attribute 'decode'openclaw migration: 3 issues (whatsapp config dropped, --overwrite appends providers, stale gateway PID) #18097 – OpenClaw migration dropped WhatsApp config keys
tools/approval.py: Add reverse shell, download-execute, and credential read patterns to DANGEROUS_PATTERNS #17873 – Security hardening for dangerous terminal command detection
DANGEROUS_PATTERNSwith reverse-shell, download-exec, and credential-read signatures.Profile creation accepts reserved names like 'main' (re-introduces #12099 in a corner case) #17879 – Reserved profile names corner case (
main)skill_view resolves by directory name but skills_list displays frontmatter name — mismatch causes 'not found' #17914 –
skill_view/skills_listname mismatchAuxiliary tasks don't inherit provider-level base_url/api_key from config #17737 – Auxiliary tasks not inheriting provider
base_url/api_keyFiles modified
agent/auxiliary_client.pygateway/platforms/email.pygateway/run.pyhermes_cli/profiles.pyoptional-skills/migration/openclaw-migration/scripts/openclaw_to_hermes.pytools/approval.pytools/skills_tool.pyReferences
Closes #18101
Closes #18106
Closes #18097
Closes #17873
Closes #17879
Closes #17914
Closes #17737