feat(dashboard): add interactive column sorting to analytics tables#18192
Merged
Conversation
19 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #17394 by @AllardQuek onto current main (330 commits ahead of the original branch). Cherry-picked cleanly; typecheck + web build pass.
What
Click-to-sort column headers on the three Analytics dashboard tables (Daily / Per-Model / Top Skills) via a
useTableSort<T>hook +SortHeadercomponent. One file:web/src/pages/AnalyticsPage.tsx(+121/-60).Changes
scripts/release.pyso changelog CI resolves the contributorValidation
npx tsc --noEmitcleannpm run buildclean (2.33s, 2047 modules)col=" keys in the new SortHeader usages map to real fields onAnalyticsDailyEntry/AnalyticsModelEntry/AnalyticsSkillEntry`Note on ModelTable default sort
Author documented the trade-off in the original PR: default changed from
input_tokens + output_tokenscombined toinput_tokensalone, so the sort hook can stay generic without computed fields. Ranking is effectively identical since input dominates output by 3–10×.Closes #17394
Fixes #17381