feat(dashboard): add interactive column sorting to analytics tables#17394
Closed
AllardQuek wants to merge 1 commit into
Closed
feat(dashboard): add interactive column sorting to analytics tables#17394AllardQuek wants to merge 1 commit into
AllardQuek wants to merge 1 commit into
Conversation
Contributor
|
Merged via #18192. Your commit was cherry-picked onto current main (your branch was ~330 commits behind, so a direct merge would've pulled in a stale tree), with your authorship preserved in git log — commit 226fd79 on main. Thanks for the contribution, @AllardQuek! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds interactive column sorting to the three analytics tables (Daily Breakdown, Per-Model Breakdown, Top Skills). Previously the tables had fixed, hardcoded ordering. Now any column header can be clicked to sort by that column, with a second click toggling asc ↔ desc.
Related Issue
Fixes #17381
Type of Change
Changes Made
web/src/pages/AnalyticsPage.tsx— addeduseTableSort<T>generic hook andSortHeadercomponent; applied sorting toDailyTable,ModelTable, andSkillTableHow to Test
cd web && npm run devand open the Analytics pageChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs