test(acp): accept prompt persistence kwargs in MCP E2E mocks#18047
Merged
ethernet8023 merged 1 commit intoApr 30, 2026
Merged
Conversation
ethernet8023
approved these changes
Apr 30, 2026
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…persist-user-message-test-mocks test(acp): accept prompt persistence kwargs in MCP E2E mocks
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
…persist-user-message-test-mocks test(acp): accept prompt persistence kwargs in MCP E2E mocks
dannyJ848
pushed a commit
to dannyJ848/hermes-agent
that referenced
this pull request
May 17, 2026
…persist-user-message-test-mocks test(acp): accept prompt persistence kwargs in MCP E2E mocks
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…persist-user-message-test-mocks test(acp): accept prompt persistence kwargs in MCP E2E mocks
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…persist-user-message-test-mocks test(acp): accept prompt persistence kwargs in MCP E2E mocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the current
maintest failure intests/acp/test_mcp_e2e.pyafter the ACP prompt path started forwardingpersist_user_messageintoAIAgent.run_conversation(...).The production agent supports that keyword, but these local E2E test doubles had narrow mock signatures. This PR makes the mocks accept future optional keyword arguments so the tests continue to exercise ACP tool-call event behavior instead of failing at the adapter boundary.
Related Issue
Fixes current
mainCI regression from Tests run25180124129.Type of Change
Changes Made
run_conversationtest doubles intests/acp/test_mcp_e2e.pyto accept**kwargs.How to Test
main:gh run view 25180124129 --repo NousResearch/hermes-agent --log-failedValidation Status
Passed locally:
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) - N/Acli-config.yaml.exampleif I added/changed config keys - N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows - N/AFor New Skills
N/A
Screenshots / Logs
Current
mainfailure: