fix(cli): exclude profiles/ from profile create --clone-all#17633
Merged
Conversation
shutil.copytree from default ~/.hermes duplicated ~/.hermes/profiles into the new profile, causing nested profiles/.../profiles/... and huge disk use. Match export behavior (_DEFAULT_EXPORT_EXCLUDE_ROOT) by ignoring the sibling profiles tree at the source root. Made-with: Cursor
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops
hermes profile create <name> --clone-allfrom recursively copying~/.hermes/profiles/into the new profile, which fills the disk.Salvage of #13129 by @hejuntt1014 onto current main + AUTHOR_MAP entry.
Changes
hermes_cli/profiles.py:shutil.copytree()now takes anignore=callback that filtersprofiles/at the source-dir root only (sibling profiles tree), matching existing_DEFAULT_EXPORT_EXCLUDE_ROOTbehavior.tests/hermes_cli/test_profiles.py: asserts siblingprofiles/tree is excluded whilememories/still copies.scripts/release.py: AUTHOR_MAP entry for @hejuntt1014.Validation
tests/hermes_cli/test_profiles.py: 93 passed, including newtest_clone_all_excludes_sibling_profiles_tree.~/.hermeswith 3 sibling profiles +memories/note.md→ cloned profile has no nestedprofiles/,config.yamlandmemories/note.mdpresent, max dir depth 1.Closes #13129.