fix(cli): exclude profiles/ from profile create --clone-all#13129
Closed
hejuntt1014 wants to merge 1 commit into
Closed
fix(cli): exclude profiles/ from profile create --clone-all#13129hejuntt1014 wants to merge 1 commit into
hejuntt1014 wants to merge 1 commit into
Conversation
shutil.copytree from default ~/.hermes duplicated ~/.hermes/profiles into the new profile, causing nested profiles/.../profiles/... and huge disk use. Match export behavior (_DEFAULT_EXPORT_EXCLUDE_ROOT) by ignoring the sibling profiles tree at the source root. Made-with: Cursor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
hermes profile create <name> --clone-allusedshutil.copytreefrom the active Hermes home. When that home is the default~/.hermes, the tree includesprofiles/(sibling named profiles). That directory was copied into the new profile, producing nested.../profiles/.../profiles/...paths and very large disk usage.Export already excludes
profilesvia_DEFAULT_EXPORT_EXCLUDE_ROOT;--clone-allshould match that behavior.How to test
pytest tests/hermes_cli/test_profiles.py::TestCreateProfile -v(new test:test_clone_all_excludes_sibling_profiles_tree).~/.hermes/profiles/other/with a marker file, runhermes profile create backup --clone-all, confirm~/.hermes/profiles/backup/profilesdoes not exist.Platform