feat(hooks): emit session:end lifecycle event (from #1432)#1725
Merged
Conversation
Adds session:end hook emitted before session:reset, giving hook authors a clean teardown signal to persist data or clean up resources before the session is destroyed. Based on PR #1564 by bayrakdarerdem (session:start portion was already on main).
Contributor
|
Thank you for your nice feedback. |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
Based on PR NousResearch#1432 by @bayrakdarerdem. session:start was already on main; this adds the session:end event. Co-authored-by: bayrakdarerdem <bayrakdarerdem@users.noreply.github.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
Based on PR NousResearch#1432 by @bayrakdarerdem. session:start was already on main; this adds the session:end event. Co-authored-by: bayrakdarerdem <bayrakdarerdem@users.noreply.github.com>
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
Based on PR NousResearch#1432 by @bayrakdarerdem. session:start was already on main; this adds the session:end event. Co-authored-by: bayrakdarerdem <bayrakdarerdem@users.noreply.github.com>
Open
1 task
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
Based on PR NousResearch#1432 by @bayrakdarerdem. session:start was already on main; this adds the session:end event. Co-authored-by: bayrakdarerdem <bayrakdarerdem@users.noreply.github.com>
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
Based on PR NousResearch#1432 by @bayrakdarerdem. session:start was already on main; this adds the session:end event. Co-authored-by: bayrakdarerdem <bayrakdarerdem@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on PR #1432 by @bayrakdarerdem. The
session:startportion of their PR was already on main, so this takes just the remaining piece: thesession:endevent.Emits
session:endbeforesession:resetwhen a user runs /new or /reset, giving hook authors a clean teardown signal to persist data or clean up resources before the session is destroyed.What changed
gateway/run.py— emitsession:endhook beforesession:resetin_handle_reset_commandgateway/hooks.py— updated docstring withsession:endevent and clarified descriptionsTest plan
Attribution
Original work by @bayrakdarerdem in PR #1432.