Skip to content

fix(install): croniter should be a core dependency, not an optional extra#17234

Closed
txbxxx wants to merge 1 commit into
NousResearch:mainfrom
txbxxx:fix/croniter-in-base-dependencies
Closed

fix(install): croniter should be a core dependency, not an optional extra#17234
txbxxx wants to merge 1 commit into
NousResearch:mainfrom
txbxxx:fix/croniter-in-base-dependencies

Conversation

@txbxxx

@txbxxx txbxxx commented Apr 29, 2026

Copy link
Copy Markdown

What

Move croniter from the [cron] optional extra into the core dependencies list in pyproject.toml.

Why

croniter is a direct import in cron/scheduler.py. The cron scheduler is a built-in feature of Hermes — it should not require a user to manually install an optional extra (hermes-agent[cron]) in order to work.

Currently:

  • croniter is only declared in [project.optional-dependencies]
  • The cron extra is not included in [all]
  • Installing hermes-agent[all] does NOT install croniter
  • After hermes update, the venv is rebuilt and croniter is lost
  • All cron jobs immediately fail with ModuleNotFoundError: No module named 'croniter'

Moving croniter into core dependencies ensures it is always present after any install or update path.

How to test

# After a fresh install
pip install hermes-agent
python -c "import croniter; print(croniter.__version__)"

# After an update
hermes update
python -c "import croniter"

What platforms tested on

Linux (WSL2). This is a dependency declaration change — no runtime code changes.

Related

Fixes the issue where hermes update silently strips croniter from the venv, causing all cron jobs to fail after every update.

@alt-glitch alt-glitch added type/bug Something isn't working comp/cron Cron scheduler and job management area/config Config system, migrations, profiles P1 High — major feature broken, no workaround labels Apr 29, 2026
@alt-glitch

alt-glitch commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Related to #16265 / #16368 (merged) which fixed the symptom (jobs silently disabled when croniter missing). This PR addresses the root cause by making croniter a core dependency so it's never missing.

@teknium1 teknium1 mentioned this pull request Apr 29, 2026
Merged
teknium1 pushed a commit that referenced this pull request Apr 29, 2026
@txbxxx @teknium1
fix(install): promote croniter to a core dependency
9ee540a 
Cron is a built-in Hermes feature (CLI `hermes cron`, `cronjob` agent
tool, gateway ticker, scheduler in cron/scheduler.py) but croniter has
been gated behind the [cron] optional extra. Users who do a plain
`pip install hermes-agent` can create jobs via /cron but any recurring
cron schedule silently returns next_run_at=None (HAS_CRONITER=False),
which then gets wrapped into a 'state=error' message only after a tick.

Move croniter into core dependencies so scheduled jobs work out of the
box on any install path. The [cron] extra is kept as an empty
passthrough so existing `pip install hermes-agent[cron]` installs and
the [all]/[termux] extras continue to resolve.

Also update the now-stale user-facing error message in
`compute_next_run()` that still tells users to install `hermes-agent[cron]`.

Salvaged from #17234 (authored by @txbxxx) with a corrected premise:
the original PR claimed [cron] wasn't in [all], but it is (pyproject.toml
line 112). The real UX problem is the plain no-extras install path,
which this fix addresses.
@teknium1

teknium1 commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Salvaged onto current main in PR #17577, now merged:

#17577

Rebuilt rather than cherry-picked — your branch had drifted well beyond the 3-line intended diff and would have reverted several unrelated features (minimax-oauth, nix workflow hardening, anthropic adapter lazy-load, lmstudio provider, BOOT.md hook, and more).

Also re-framed the PR body. Your specific claim — that [cron] isn't in [all] — is actually wrong: [cron] is listed in [all] on pyproject.toml line 112, and was when you filed. So pip install hermes-agent[all] would have pulled croniter fine. But the deeper point you were making is right: cron is a built-in feature (CLI hermes cron, gateway ticker, cronjob agent tool) and should work on a plain pip install hermes-agent without any extras. That's the bare-install UX gap that actually got fixed.

Your authorship is preserved on the fix commit in main (3520c37fd). Thanks for pushing on the right instinct even though the framing was off.

@teknium1 teknium1 closed this Apr 29, 2026
sunJose pushed a commit to sunJose/hermes-agent that referenced this pull request Apr 30, 2026
@txbxxx @sunleo888888
fix(install): promote croniter to a core dependency
b4deed4 
Cron is a built-in Hermes feature (CLI `hermes cron`, `cronjob` agent
tool, gateway ticker, scheduler in cron/scheduler.py) but croniter has
been gated behind the [cron] optional extra. Users who do a plain
`pip install hermes-agent` can create jobs via /cron but any recurring
cron schedule silently returns next_run_at=None (HAS_CRONITER=False),
which then gets wrapped into a 'state=error' message only after a tick.

Move croniter into core dependencies so scheduled jobs work out of the
box on any install path. The [cron] extra is kept as an empty
passthrough so existing `pip install hermes-agent[cron]` installs and
the [all]/[termux] extras continue to resolve.

Also update the now-stale user-facing error message in
`compute_next_run()` that still tells users to install `hermes-agent[cron]`.

Salvaged from NousResearch#17234 (authored by @txbxxx) with a corrected premise:
the original PR claimed [cron] wasn't in [all], but it is (pyproject.toml
line 112). The real UX problem is the plain no-extras install path,
which this fix addresses.
nickdlkk pushed a commit to nickdlkk/hermes-agent that referenced this pull request May 11, 2026
@txbxxx @nickdlkk
fix(install): promote croniter to a core dependency
851f63a 
Cron is a built-in Hermes feature (CLI `hermes cron`, `cronjob` agent
tool, gateway ticker, scheduler in cron/scheduler.py) but croniter has
been gated behind the [cron] optional extra. Users who do a plain
`pip install hermes-agent` can create jobs via /cron but any recurring
cron schedule silently returns next_run_at=None (HAS_CRONITER=False),
which then gets wrapped into a 'state=error' message only after a tick.

Move croniter into core dependencies so scheduled jobs work out of the
box on any install path. The [cron] extra is kept as an empty
passthrough so existing `pip install hermes-agent[cron]` installs and
the [all]/[termux] extras continue to resolve.

Also update the now-stale user-facing error message in
`compute_next_run()` that still tells users to install `hermes-agent[cron]`.

Salvaged from NousResearch#17234 (authored by @txbxxx) with a corrected premise:
the original PR claimed [cron] wasn't in [all], but it is (pyproject.toml
line 112). The real UX problem is the plain no-extras install path,
which this fix addresses.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
@txbxxx @teknium1
fix(install): promote croniter to a core dependency
22b73a2 
Cron is a built-in Hermes feature (CLI `hermes cron`, `cronjob` agent
tool, gateway ticker, scheduler in cron/scheduler.py) but croniter has
been gated behind the [cron] optional extra. Users who do a plain
`pip install hermes-agent` can create jobs via /cron but any recurring
cron schedule silently returns next_run_at=None (HAS_CRONITER=False),
which then gets wrapped into a 'state=error' message only after a tick.

Move croniter into core dependencies so scheduled jobs work out of the
box on any install path. The [cron] extra is kept as an empty
passthrough so existing `pip install hermes-agent[cron]` installs and
the [all]/[termux] extras continue to resolve.

Also update the now-stale user-facing error message in
`compute_next_run()` that still tells users to install `hermes-agent[cron]`.

Salvaged from NousResearch#17234 (authored by @txbxxx) with a corrected premise:
the original PR claimed [cron] wasn't in [all], but it is (pyproject.toml
line 112). The real UX problem is the plain no-extras install path,
which this fix addresses.
jsboige pushed a commit to jsboige/hermes-agent that referenced this pull request May 14, 2026
@txbxxx @teknium1
fix(install): promote croniter to a core dependency
78a7813 
Cron is a built-in Hermes feature (CLI `hermes cron`, `cronjob` agent
tool, gateway ticker, scheduler in cron/scheduler.py) but croniter has
been gated behind the [cron] optional extra. Users who do a plain
`pip install hermes-agent` can create jobs via /cron but any recurring
cron schedule silently returns next_run_at=None (HAS_CRONITER=False),
which then gets wrapped into a 'state=error' message only after a tick.

Move croniter into core dependencies so scheduled jobs work out of the
box on any install path. The [cron] extra is kept as an empty
passthrough so existing `pip install hermes-agent[cron]` installs and
the [all]/[termux] extras continue to resolve.

Also update the now-stale user-facing error message in
`compute_next_run()` that still tells users to install `hermes-agent[cron]`.

Salvaged from NousResearch#17234 (authored by @txbxxx) with a corrected premise:
the original PR claimed [cron] wasn't in [all], but it is (pyproject.toml
line 112). The real UX problem is the plain no-extras install path,
which this fix addresses.
dannyJ848 pushed a commit to dannyJ848/hermes-agent that referenced this pull request May 17, 2026
@txbxxx @teknium1
fix(install): promote croniter to a core dependency
1addeb4 
Cron is a built-in Hermes feature (CLI `hermes cron`, `cronjob` agent
tool, gateway ticker, scheduler in cron/scheduler.py) but croniter has
been gated behind the [cron] optional extra. Users who do a plain
`pip install hermes-agent` can create jobs via /cron but any recurring
cron schedule silently returns next_run_at=None (HAS_CRONITER=False),
which then gets wrapped into a 'state=error' message only after a tick.

Move croniter into core dependencies so scheduled jobs work out of the
box on any install path. The [cron] extra is kept as an empty
passthrough so existing `pip install hermes-agent[cron]` installs and
the [all]/[termux] extras continue to resolve.

Also update the now-stale user-facing error message in
`compute_next_run()` that still tells users to install `hermes-agent[cron]`.

Salvaged from NousResearch#17234 (authored by @txbxxx) with a corrected premise:
the original PR claimed [cron] wasn't in [all], but it is (pyproject.toml
line 112). The real UX problem is the plain no-extras install path,
which this fix addresses.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
@txbxxx @teknium1
fix(install): promote croniter to a core dependency
c520b6f 
Cron is a built-in Hermes feature (CLI `hermes cron`, `cronjob` agent
tool, gateway ticker, scheduler in cron/scheduler.py) but croniter has
been gated behind the [cron] optional extra. Users who do a plain
`pip install hermes-agent` can create jobs via /cron but any recurring
cron schedule silently returns next_run_at=None (HAS_CRONITER=False),
which then gets wrapped into a 'state=error' message only after a tick.

Move croniter into core dependencies so scheduled jobs work out of the
box on any install path. The [cron] extra is kept as an empty
passthrough so existing `pip install hermes-agent[cron]` installs and
the [all]/[termux] extras continue to resolve.

Also update the now-stale user-facing error message in
`compute_next_run()` that still tells users to install `hermes-agent[cron]`.

Salvaged from NousResearch#17234 (authored by @txbxxx) with a corrected premise:
the original PR claimed [cron] wasn't in [all], but it is (pyproject.toml
line 112). The real UX problem is the plain no-extras install path,
which this fix addresses.
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
@txbxxx @teknium1
fix(install): promote croniter to a core dependency
aada92d 
Cron is a built-in Hermes feature (CLI `hermes cron`, `cronjob` agent
tool, gateway ticker, scheduler in cron/scheduler.py) but croniter has
been gated behind the [cron] optional extra. Users who do a plain
`pip install hermes-agent` can create jobs via /cron but any recurring
cron schedule silently returns next_run_at=None (HAS_CRONITER=False),
which then gets wrapped into a 'state=error' message only after a tick.

Move croniter into core dependencies so scheduled jobs work out of the
box on any install path. The [cron] extra is kept as an empty
passthrough so existing `pip install hermes-agent[cron]` installs and
the [all]/[termux] extras continue to resolve.

Also update the now-stale user-facing error message in
`compute_next_run()` that still tells users to install `hermes-agent[cron]`.

Salvaged from NousResearch#17234 (authored by @txbxxx) with a corrected premise:
the original PR claimed [cron] wasn't in [all], but it is (pyproject.toml
line 112). The real UX problem is the plain no-extras install path,
which this fix addresses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/config Config system, migrations, profiles comp/cron Cron scheduler and job management P1 High — major feature broken, no workaround type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@txbxxx @alt-glitch @teknium1