fix(config): add request_timeout_seconds and stale_timeout_seconds to provider _KNOWN_KEYS#16853
Closed
vominh1919 wants to merge 1 commit into
Closed
fix(config): add request_timeout_seconds and stale_timeout_seconds to provider _KNOWN_KEYS#16853vominh1919 wants to merge 1 commit into
vominh1919 wants to merge 1 commit into
Conversation
… provider _KNOWN_KEYS Both keys are documented in cli-config.yaml.example and read at runtime by hermes_cli/timeouts.py (get_provider_request_timeout and get_provider_stale_timeout), but the provider-entry validator in config.py flagged them as unknown, producing noisy warnings on every CLI invocation for users who followed the documented config. Fixes NousResearch#16779
Collaborator
1 similar comment
Collaborator
Contributor
|
Merged via #16908 — your commit was cherry-picked onto current main with authorship preserved in git log. Thanks @vominh1919! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
request_timeout_secondsandstale_timeout_secondsto the_KNOWN_KEYSset inhermes_cli/config.pyso the provider-entry validator recognizes them as valid config keys.Why
Both keys are:
cli-config.yaml.example(lines 87–88, 90, 97)hermes_cli/timeouts.py—get_provider_request_timeout()(line 40) andget_provider_stale_timeout()(line 69)But the validator's
_KNOWN_KEYSset (line 2195) was missing them, so every CLI invocation logged a noisy warning for users who followed the documented config:How
"request_timeout_seconds", "stale_timeout_seconds"to the_KNOWN_KEYSfrozenset.test_timeout_keys_not_flagged_unknownverifies that these keys no longer trigger the warning.Before vs After
Before:
After:
Fixes #16779