fix(config): add request_timeout_seconds and stale_timeout_seconds to provider _KNOWN_KEYS (#16779)#16812
Closed
vominh1919 wants to merge 1 commit into
Closed
Conversation
… provider _KNOWN_KEYS (NousResearch#16779) The provider-entry validator in hermes_cli/config.py warns on request_timeout_seconds and stale_timeout_seconds as "unknown config keys ignored" even though those are valid keys read by hermes_cli/timeouts.py and documented in cli-config.yaml.example. Add both keys to _KNOWN_KEYS so the false warning is suppressed. Fixes NousResearch#16779
Collaborator
Contributor
|
Closing as already fixed on Triage notes (high confidence): If you still see this on the latest version, please reopen with reproduction steps. (Bulk-closed during a CLI triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The provider-entry validator in
hermes_cli/config.pyhas a_KNOWN_KEYSset that's out of sync with both the documented config example and the runtime code. It warns onrequest_timeout_secondsandstale_timeout_secondsas "unknown config keys ignored" even though those are:hermes_cli/timeouts.py:40readsprovider_config.get("request_timeout_seconds")and:69readsprovider_config.get("stale_timeout_seconds")cli-config.yaml.exampleshows both keys in theproviders:sectionFix
Add both keys to the
_KNOWN_KEYSset (one-line change).File changed:
hermes_cli/config.py(+2 lines in set literal)Impact
Eliminates false warnings for users who configure per-provider timeouts as documented. No behavioral change — the keys already work; this just stops the spurious warning.
Fixes #16779