fix(delegation): classify terminal trace status by exit_code#16162
Closed
ChuckChambers wants to merge 1 commit into
Closed
fix(delegation): classify terminal trace status by exit_code#16162ChuckChambers wants to merge 1 commit into
ChuckChambers wants to merge 1 commit into
Conversation
Collaborator
|
Likely duplicate of #13898 — same root cause: delegate_tool.py naive string heuristic marks exit_code:0 terminal results as errors when output contains 'error'. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix delegation observability so terminal tool traces are classified by structured
exit_codewhen present, instead of substring matching on the worderror.Previously a successful terminal result such as:
{"output":"error count: 0", "exit_code": 0, "error": null}was marked as
status: "error"intool_tracebecause the serialized result contained the stringerrornear the beginning.Changes
_looks_like_error_output()to treat JSON results withexit_codeas terminal-style results.exit_code == 0=> not an error.exit_code=> error._looks_like_error_output()for_run_single_child()tool_tracestatus.errorwithexit_code: 0.Test plan
source venv/bin/activate pytest -q tests/tools/test_delegate.py -qResult: passed.