fix: correct delegation tool trace error detection#13898
Closed
Y0914 wants to merge 1 commit into
Closed
Conversation
Author
|
Root cause summary:
What this PR changes:
How I verified it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Delegation observability was misclassifying successful tool calls as errors in
tool_trace.Root Cause
tools/delegate_tool.pyused a naive string heuristic that marked a tool result as an error whenever the returned content contained the worderrornear the start. That incorrectly flagged successful terminal JSON payloads like{\"error\": null, \"exit_code\": 0, ...}.Fix
error: nullsuccess payloads and non-zero exit codesHow to Verify
source venv/bin/activate && python -m pytest tests/tools/test_delegate.py -qdelegate_taskwithtoolsets=[\"terminal\"]for a read-only command likehostname && pwdtool_trace[0].statusisokinstead oferrorTest Plan
Risk Assessment
Low — the change is narrowly scoped to delegation observability/status classification and is covered by targeted regression tests.