Skip to content

fix(doctor): accept bare custom provider#15823

Merged
teknium1 merged 1 commit into
mainfrom
salvage/doctor-bare-custom
Apr 26, 2026
Merged

fix(doctor): accept bare custom provider#15823
teknium1 merged 1 commit into
mainfrom
salvage/doctor-bare-custom

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvage of #15781 by @helix4u onto current main.

Summary

hermes doctor no longer fails config validation for model.provider: custom. Previously listed custom as a known provider and then rejected it as unknown in the same check.

Root cause

known_providers includes bare custom, but _resolve_provider_full("custom", ...) only handles named entries (custom:neuralwatt) and returns None, tripping the fail branch.

Fix

Skip the resolver for custom like we already do for auto. 5 lines in hermes_cli/doctor.py + regression test.

Validation

scripts/run_tests.sh tests/hermes_cli/test_doctor.py — 23/23 passed.

Credit: @helix4u (authorship preserved via cherry-pick). Closes #15781.

@teknium1 teknium1 merged commit b2d3308 into main Apr 26, 2026
10 of 12 checks passed
@teknium1 teknium1 deleted the salvage/doctor-bare-custom branch April 26, 2026 01:01
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles labels Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants