fix(doctor): accept bare custom provider#15823
Merged
Merged
Conversation
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #15781 by @helix4u onto current main.
Summary
hermes doctorno longer fails config validation formodel.provider: custom. Previously listedcustomas a known provider and then rejected it as unknown in the same check.Root cause
known_providersincludes barecustom, but_resolve_provider_full("custom", ...)only handles named entries (custom:neuralwatt) and returns None, tripping the fail branch.Fix
Skip the resolver for
customlike we already do forauto. 5 lines inhermes_cli/doctor.py+ regression test.Validation
scripts/run_tests.sh tests/hermes_cli/test_doctor.py— 23/23 passed.Credit: @helix4u (authorship preserved via cherry-pick). Closes #15781.