fix(doctor): accept bare custom provider#15781
Closed
helix4u wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.provider: customas valid inhermes doctor.custom:neuralwatton the existing resolver path.Why
hermes doctoralready includescustomin its known-provider set, but then tried to resolve it through the named/custom provider resolver. That resolver returns entries for named providers such ascustom:neuralwatt, but not the bare anonymouscustomprovider, so doctor reported a valid config as unknown while also listingcustomas valid.Test plan
scripts/run_tests.sh tests/hermes_cli/test_doctor.py -k "bare_custom_provider or named_provider_from_providers_section": 2 passed, 2 warningsscripts/run_tests.sh: 66 failed, 15628 passed, 40 skipped, 184 warnings in 359.48sThe full-suite failures are outside this doctor change and match the current unrelated failing areas in gateway/provider tests.