fix(tui): honor launch model overrides by OutThisLife · Pull Request #15755 · NousResearch/hermes-agent

OutThisLife · 2026-04-25T18:22:09Z

Summary

Pass --tui -m/--model and --provider into the TUI child process so startup uses the launch-selected model/provider.
Keep TUI startup provider resolution deterministic: explicit HERMES_TUI_PROVIDER wins, while ambient inference provider stays in config-first resolution.
Avoid startup network lookups by sharing static provider detection from hermes_cli.models, including short aliases like sonnet/opus.
Bind /provider as a real alias of /model in both CLI command metadata and TUI slash handling/completion.
Add reusable TUI overlay helpers (useOverlayKeys, OverlayHint, windowOffset/windowItems) so picker-style overlays share Esc/q close behavior, consistent hints, and list windowing.
Run npm run fix for ui-tui and fix a type-check failure in hermes-ink by guarding cache-key eviction when the map iterator is empty.

Test plan

scripts/run_tests.sh tests/hermes_cli/test_tui_resume_flow.py tests/test_tui_gateway_server.py tests/hermes_cli/test_models.py
scripts/run_tests.sh tests/hermes_cli/test_models.py tests/test_tui_gateway_server.py
scripts/run_tests.sh tests/test_tui_gateway_server.py::test_config_set_model_syncs_tui_provider_env tests/test_tui_gateway_server.py::test_config_set_model_syncs_inference_provider_env tests/hermes_cli/test_models.py::TestDetectProviderForModel
npm run fix && npm run type-check (in ui-tui)
npm test -- src/__tests__/createSlashHandler.test.ts (in ui-tui)
git diff --check

Copilot

Pull request overview

This PR fixes hermes --tui -m/--model (and --provider) launch overrides by exporting them into the TUI process environment and teaching the TUI gateway to honor those startup overrides (including provider auto-detection for model-only launches).

Changes:

Export --model/--provider into the TUI child process via HERMES_MODEL / HERMES_INFERENCE_MODEL and HERMES_TUI_PROVIDER / HERMES_INFERENCE_PROVIDER.
Add gateway-side startup resolution that selects the correct model/provider when constructing AIAgent, including provider detection when only a model override is provided.
Add/extend tests covering env-based model resolution and startup runtime behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`tui_gateway/server.py`	Adds startup model/provider resolution and uses it when creating `AIAgent`.
`hermes_cli/main.py`	Passes CLI `--model/--provider` through to the TUI child process via env vars; updates CLI help text.
`tests/test_tui_gateway_server.py`	Adds tests for `_resolve_model()` and `_resolve_startup_runtime()` behavior with env overrides and provider detection.
`tests/hermes_cli/test_tui_resume_flow.py`	Extends TUI resume/launch tests to ensure model/provider are passed through and exported.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- run the requested ui-tui lint+format pass and include resulting formatting updates - guard text-measure cache eviction key in hermes-ink so ui-tui type-check stays green

Copilot

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- expand short model aliases like sonnet/opus via static catalogs during startup runtime resolution - keep startup alias resolution network-free and add regression tests in models and tui gateway suites

Copilot

Pull request overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- add reusable overlay key and help-text helpers for picker-style overlays - make model, session, skills, and pager hints consistently support Esc/q close behavior

- keep HERMES_INFERENCE_MODEL aligned with HERMES_MODEL after in-TUI model switches - clarify static provider detection remapping docs

- rename overlay help text component to match its role - share picker window math across model, session, and skills overlays

Copilot

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

ui-tui/src/components/skillsHub.tsx:73

useOverlayKeys is disabled while installing is true, so Esc/q won’t work during installs, but the rendered help text in the actions view still advertises Enter/Esc back · q close. Either allow close/back during installs (remove disabled: installing) or conditionally update the help text while installing so the UI doesn’t suggest unavailable shortcuts.

      .catch((e: unknown) => setErr(rpcErrorMessage(e)))
  }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Keep shared overlay close behavior consistent with pager and agents overlays by binding lowercase q only.

@Bartok9

#16897) `/new` after `/model <custom-provider>:<model>` silently reverted to a native provider whose static catalog happened to contain the same model name (e.g. `deepseek-v4-pro` → native `deepseek` → 401). Root cause at the `/model` writeback site: `HERMES_INFERENCE_PROVIDER` was set unconditionally but `HERMES_TUI_PROVIDER` was only mirrored when it was already set. On sessions launched without `--provider`, `HERMES_TUI_PROVIDER` stayed unset, so `_resolve_startup_runtime()` on `/new` skipped the explicit-provider early return and fell through to `detect_static_provider_for_model()`. Fix: set `HERMES_TUI_PROVIDER` unconditionally alongside `HERMES_INFERENCE_PROVIDER` when `/model` lands. Keeps #15755's invariant intact — `HERMES_TUI_PROVIDER` remains the canonical "explicit this process" carrier, `HERMES_INFERENCE_PROVIDER` remains ambient and does not short-circuit startup resolution. Bug report and diagnosis: @Bartok9 in #16857 / #16873. Fixes #16857

@Bartok9

…) (#16897) `/new` after `/model <custom-provider>:<model>` silently reverted to a native provider whose static catalog happened to contain the same model name (e.g. `deepseek-v4-pro` → native `deepseek` → 401). Root cause at the `/model` writeback site: `HERMES_INFERENCE_PROVIDER` was set unconditionally but `HERMES_TUI_PROVIDER` was only mirrored when it was already set. On sessions launched without `--provider`, `HERMES_TUI_PROVIDER` stayed unset, so `_resolve_startup_runtime()` on `/new` skipped the explicit-provider early return and fell through to `detect_static_provider_for_model()`. Fix: set `HERMES_TUI_PROVIDER` unconditionally alongside `HERMES_INFERENCE_PROVIDER` when `/model` lands. Keeps #15755's invariant intact — `HERMES_TUI_PROVIDER` remains the canonical "explicit this process" carrier, `HERMES_INFERENCE_PROVIDER` remains ambient and does not short-circuit startup resolution. Bug report and diagnosis: @Bartok9 in #16857 / #16873. Fixes #16857

…flag fix(tui): honor launch model overrides

@Bartok9

…search#16857) (NousResearch#16897) `/new` after `/model <custom-provider>:<model>` silently reverted to a native provider whose static catalog happened to contain the same model name (e.g. `deepseek-v4-pro` → native `deepseek` → 401). Root cause at the `/model` writeback site: `HERMES_INFERENCE_PROVIDER` was set unconditionally but `HERMES_TUI_PROVIDER` was only mirrored when it was already set. On sessions launched without `--provider`, `HERMES_TUI_PROVIDER` stayed unset, so `_resolve_startup_runtime()` on `/new` skipped the explicit-provider early return and fell through to `detect_static_provider_for_model()`. Fix: set `HERMES_TUI_PROVIDER` unconditionally alongside `HERMES_INFERENCE_PROVIDER` when `/model` lands. Keeps NousResearch#15755's invariant intact — `HERMES_TUI_PROVIDER` remains the canonical "explicit this process" carrier, `HERMES_INFERENCE_PROVIDER` remains ambient and does not short-circuit startup resolution. Bug report and diagnosis: @Bartok9 in NousResearch#16857 / NousResearch#16873. Fixes NousResearch#16857

…flag fix(tui): honor launch model overrides

@Bartok9

…search#16857) (NousResearch#16897) `/new` after `/model <custom-provider>:<model>` silently reverted to a native provider whose static catalog happened to contain the same model name (e.g. `deepseek-v4-pro` → native `deepseek` → 401). Root cause at the `/model` writeback site: `HERMES_INFERENCE_PROVIDER` was set unconditionally but `HERMES_TUI_PROVIDER` was only mirrored when it was already set. On sessions launched without `--provider`, `HERMES_TUI_PROVIDER` stayed unset, so `_resolve_startup_runtime()` on `/new` skipped the explicit-provider early return and fell through to `detect_static_provider_for_model()`. Fix: set `HERMES_TUI_PROVIDER` unconditionally alongside `HERMES_INFERENCE_PROVIDER` when `/model` lands. Keeps NousResearch#15755's invariant intact — `HERMES_TUI_PROVIDER` remains the canonical "explicit this process" carrier, `HERMES_INFERENCE_PROVIDER` remains ambient and does not short-circuit startup resolution. Bug report and diagnosis: @Bartok9 in NousResearch#16857 / NousResearch#16873. Fixes NousResearch#16857

…flag fix(tui): honor launch model overrides

@Bartok9

…search#16857) (NousResearch#16897) `/new` after `/model <custom-provider>:<model>` silently reverted to a native provider whose static catalog happened to contain the same model name (e.g. `deepseek-v4-pro` → native `deepseek` → 401). Root cause at the `/model` writeback site: `HERMES_INFERENCE_PROVIDER` was set unconditionally but `HERMES_TUI_PROVIDER` was only mirrored when it was already set. On sessions launched without `--provider`, `HERMES_TUI_PROVIDER` stayed unset, so `_resolve_startup_runtime()` on `/new` skipped the explicit-provider early return and fell through to `detect_static_provider_for_model()`. Fix: set `HERMES_TUI_PROVIDER` unconditionally alongside `HERMES_INFERENCE_PROVIDER` when `/model` lands. Keeps NousResearch#15755's invariant intact — `HERMES_TUI_PROVIDER` remains the canonical "explicit this process" carrier, `HERMES_INFERENCE_PROVIDER` remains ambient and does not short-circuit startup resolution. Bug report and diagnosis: @Bartok9 in NousResearch#16857 / NousResearch#16873. Fixes NousResearch#16857

…flag fix(tui): honor launch model overrides

@Bartok9

…search#16857) (NousResearch#16897) `/new` after `/model <custom-provider>:<model>` silently reverted to a native provider whose static catalog happened to contain the same model name (e.g. `deepseek-v4-pro` → native `deepseek` → 401). Root cause at the `/model` writeback site: `HERMES_INFERENCE_PROVIDER` was set unconditionally but `HERMES_TUI_PROVIDER` was only mirrored when it was already set. On sessions launched without `--provider`, `HERMES_TUI_PROVIDER` stayed unset, so `_resolve_startup_runtime()` on `/new` skipped the explicit-provider early return and fell through to `detect_static_provider_for_model()`. Fix: set `HERMES_TUI_PROVIDER` unconditionally alongside `HERMES_INFERENCE_PROVIDER` when `/model` lands. Keeps NousResearch#15755's invariant intact — `HERMES_TUI_PROVIDER` remains the canonical "explicit this process" carrier, `HERMES_INFERENCE_PROVIDER` remains ambient and does not short-circuit startup resolution. Bug report and diagnosis: @Bartok9 in NousResearch#16857 / NousResearch#16873. Fixes NousResearch#16857

…flag fix(tui): honor launch model overrides

@Bartok9

…search#16857) (NousResearch#16897) `/new` after `/model <custom-provider>:<model>` silently reverted to a native provider whose static catalog happened to contain the same model name (e.g. `deepseek-v4-pro` → native `deepseek` → 401). Root cause at the `/model` writeback site: `HERMES_INFERENCE_PROVIDER` was set unconditionally but `HERMES_TUI_PROVIDER` was only mirrored when it was already set. On sessions launched without `--provider`, `HERMES_TUI_PROVIDER` stayed unset, so `_resolve_startup_runtime()` on `/new` skipped the explicit-provider early return and fell through to `detect_static_provider_for_model()`. Fix: set `HERMES_TUI_PROVIDER` unconditionally alongside `HERMES_INFERENCE_PROVIDER` when `/model` lands. Keeps NousResearch#15755's invariant intact — `HERMES_TUI_PROVIDER` remains the canonical "explicit this process" carrier, `HERMES_INFERENCE_PROVIDER` remains ambient and does not short-circuit startup resolution. Bug report and diagnosis: @Bartok9 in NousResearch#16857 / NousResearch#16873. Fixes NousResearch#16857

fix(tui): honor launch model overrides

e9c47c7

OutThisLife requested a review from Copilot April 25, 2026 18:24

Copilot started reviewing on behalf of OutThisLife April 25, 2026 18:24 View session

fix(tui): preserve provider precedence on startup

57b43fd

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread tui_gateway/server.py

Comment thread tui_gateway/server.py

fix(tui): address startup provider review

4db58d4

OutThisLife requested a review from Copilot April 25, 2026 18:39

Copilot started reviewing on behalf of OutThisLife April 25, 2026 18:39 View session

alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/tui Terminal UI (ui-tui/ + tui_gateway/) comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 25, 2026

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread tui_gateway/server.py

Comment thread tests/test_tui_gateway_server.py

fix(tui): avoid network lookup during startup

2dfcc80

OutThisLife requested a review from Copilot April 25, 2026 18:49

Copilot started reviewing on behalf of OutThisLife April 25, 2026 18:49 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread tui_gateway/server.py Outdated

OutThisLife added 2 commits April 25, 2026 13:56

fix(tui): share static model detection

e48a497

fix(tui): bind provider as model alias

5e52011

OutThisLife requested a review from Copilot April 25, 2026 19:02

Copilot started reviewing on behalf of OutThisLife April 25, 2026 19:03 View session

fix(tui): apply ui-tui fix pass and restore type-check

48bdd24

- run the requested ui-tui lint+format pass and include resulting formatting updates - guard text-measure cache eviction key in hermes-ink so ui-tui type-check stays green

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread tui_gateway/server.py

OutThisLife requested a review from Copilot April 25, 2026 19:10

Copilot started reviewing on behalf of OutThisLife April 25, 2026 19:10 View session

fix(tui): resolve startup model aliases statically

fdcbd22

- expand short model aliases like sonnet/opus via static catalogs during startup runtime resolution - keep startup alias resolution network-free and add regression tests in models and tui gateway suites

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread tui_gateway/server.py

Comment thread hermes_cli/models.py

OutThisLife added 2 commits April 25, 2026 14:17

fix(tui): share overlay close controls

a046483

- add reusable overlay key and help-text helpers for picker-style overlays - make model, session, skills, and pager hints consistently support Esc/q close behavior

fix(tui): sync inference model after switches

c6fdf48

- keep HERMES_INFERENCE_MODEL aligned with HERMES_MODEL after in-TUI model switches - clarify static provider detection remapping docs

OutThisLife requested a review from Copilot April 25, 2026 19:19

Copilot started reviewing on behalf of OutThisLife April 25, 2026 19:20 View session

refactor(tui): tighten overlay helpers

6e83d90

- rename overlay help text component to match its role - share picker window math across model, session, and skills overlays

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread ui-tui/src/components/overlayControls.tsx

Comment thread ui-tui/src/components/overlayControls.tsx

fix(tui): align overlay q shortcut casing

919274b

Keep shared overlay close behavior consistent with pager and agents overlays by binding lowercase q only.

OutThisLife merged commit 283c8fd into main Apr 25, 2026
10 of 12 checks passed

OutThisLife deleted the bb/tui-model-flag branch April 25, 2026 19:30

teknium1 mentioned this pull request Apr 28, 2026

fix(tui): /model writes HERMES_TUI_PROVIDER unconditionally (#16857) #16897

Merged

teknium1 mentioned this pull request Apr 28, 2026

fix(gateway): honour HERMES_INFERENCE_PROVIDER in _resolve_startup_runtime (#16857) #16873

Closed

This was referenced Apr 28, 2026

TUI: hermes --tui shows "Setup Required" for bedrock/anthropic-native configs — _make_agent drops provider/api_mode #12381

Closed

[Bug]: Ink TUI: bare-slug model + provider in config yields HTTP 404 at api.anthropic.com #11884

Closed

ulasbilgen pushed a commit to ulasbilgen/hermes-adhd-agent that referenced this pull request May 1, 2026

Merge pull request NousResearch#15755 from NousResearch/bb/tui-model-…

d992164

…flag fix(tui): honor launch model overrides

02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026

Merge pull request NousResearch#15755 from NousResearch/bb/tui-model-…

8a39eaf

…flag fix(tui): honor launch model overrides

dannyJ848 pushed a commit to dannyJ848/hermes-agent that referenced this pull request May 17, 2026

Merge pull request NousResearch#15755 from NousResearch/bb/tui-model-…

6289698

…flag fix(tui): honor launch model overrides

gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026

Merge pull request NousResearch#15755 from NousResearch/bb/tui-model-…

e72a0f9

…flag fix(tui): honor launch model overrides

Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026

Merge pull request NousResearch#15755 from NousResearch/bb/tui-model-…

0c318d6

…flag fix(tui): honor launch model overrides

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tui): honor launch model overrides#15755

fix(tui): honor launch model overrides#15755
OutThisLife merged 12 commits into
mainfrom
bb/tui-model-flag

OutThisLife commented Apr 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

OutThisLife commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OutThisLife commented Apr 25, 2026 •

edited

Loading