fix(agent): recognize emoji as natural response endings in stop-to-length heuristic (#14572)#15363
Closed
Tranquil-Flow wants to merge 1 commit into
Closed
Conversation
Collaborator
5 tasks
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_has_natural_response_ending()checks whether the last character of a response is in a hardcoded punctuation charset. Emoji characters (common sign-offs like🌙,✅,👍,🎉) are not in this charset, so responses ending with emoji are incorrectly classified as "truncated" by_should_treat_stop_as_truncated(). This causes silent retry loops for Ollama/GLM users whose responses naturally end with emoji.The fix adds a Unicode category check — characters in categories starting with
S(Symbol: So, Sk, Sm, Sc) are treated as natural endings.Related Issue
Fixes #14572
Type of Change
Changes Made
run_agent.py: After the existing punctuation check, add a Unicode category check — characters in categories starting withS(Symbol: So, Sk, Sm, Sc) are treated as natural endings.How to Test
Validation table:
"Thank you! 🌙"False→ retried as truncatedTrue→ accepted"Done ✅"False→ retriedTrue→ accepted"Normal ending."TrueTrue(unchanged)"No ending here"FalseFalse(unchanged)Tested on macOS (Python 3.14).
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs