fix(agent): accept emoji sign-offs as natural endings#14574
Conversation
|
Nice fix! A couple of suggestions from our implementation (#25991, closed in favor of this one) that proved important in testing: 1. 500-character minimum gate Most false positives come from short conversational replies ("Based on the results, the best next" — 39 chars), not just emoji. These short responses can't possibly hit token limits, so they're almost certainly complete. Adding a length gate eliminates the vast majority of false positives before we even check the ending character. In if len(visible_text) < 500:
return False2. Config opt-out Some users may want to disable the heuristic entirely. A config flag with default Your Happy to help with either addition if useful. |
Summary
💛Testing
Closes #14572