fix(tui): harden terminal dimming and multiplexer copy#14906
Merged
Conversation
- disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens TUI terminal compatibility by changing defaults for ANSI dim (on VTE terminals) and OSC52 clipboard emission (in local multiplexers), with environment-variable overrides and regression tests.
Changes:
- Add
shouldUseAnsiDim()and gatedimstyling to disable ANSI dim by default on VTE terminals (override viaHERMES_TUI_DIM). - Add
shouldEmitClipboardSequence()and suppress OSC52 clipboard sequences by default in local tmux/screen sessions (override viaHERMES_TUI_CLIPBOARD_OSC52/HERMES_TUI_COPY_OSC52), while keeping remote behavior. - Add Vitest coverage for both new compatibility decisions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui-tui/packages/hermes-ink/src/ink/termio/osc.ts | Adds env-driven OSC52 emission decision and applies it to setClipboard(). |
| ui-tui/packages/hermes-ink/src/ink/termio/osc.test.ts | Adds tests for OSC52 emission decision defaults and overrides. |
| ui-tui/packages/hermes-ink/src/ink/components/Text.tsx | Adds env-driven ANSI dim decision and gates dim usage accordingly. |
| ui-tui/packages/hermes-ink/src/ink/components/Text.test.ts | Adds tests for ANSI dim decision defaults and override behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+86
to
+88
| export function shouldEmitClipboardSequence(env: NodeJS.ProcessEnv = process.env): boolean { | ||
| const override = (env.HERMES_TUI_CLIPBOARD_OSC52 ?? env.HERMES_TUI_COPY_OSC52 ?? '').trim() | ||
|
|
There was a problem hiding this comment.
The parameter name env in shouldEmitClipboardSequence shadows the imported env helper from ../../utils/env.js used elsewhere in this module (e.g., osc()). This makes the code harder to read/grep and can lead to accidental misuse. Consider renaming the parameter to something like processEnv or envVars.
Comment on lines
+97
to
+98
| return !!env['SSH_CONNECTION'] || (!env['TMUX'] && !env['STY']) | ||
| } |
There was a problem hiding this comment.
With the new default (!env['TMUX'] && !env['STY']), local GNU screen sessions (STY set, no SSH_CONNECTION) will suppress OSC52 emission, but getClipboardPath() still returns 'osc52' for screen because it only checks TMUX. That can make caller UX/toasts inaccurate and also removes the previous OSC52 fallback when no native clipboard tool is available. Consider updating getClipboardPath() to incorporate the new emission decision (or add a 'native-only'/'none' path when emission is suppressed).
nekorytaylor666
pushed a commit
to nekorytaylor666/hermes-agent
that referenced
this pull request
Apr 24, 2026
…14906) - disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
justrhoto
pushed a commit
to justrhoto/hermes-agent
that referenced
this pull request
Apr 24, 2026
…14906) - disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
…14906) - disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
aj-nt
pushed a commit
to aj-nt/hermes-agent
that referenced
this pull request
May 1, 2026
…14906) - disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
donald131
pushed a commit
to donald131/hermes-agent
that referenced
this pull request
May 2, 2026
…14906) - disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
6 tasks
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…14906) - disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…14906) - disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…14906) - disable ANSI dim on VTE terminals by default so dark-background reasoning and accents stay readable - suppress local multiplexer OSC52 echo while preserving remote passthrough and add regression coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cd ui-tui && ./node_modules/.bin/vitest runcd ui-tui && ./node_modules/.bin/tsc --noEmit -p tsconfig.json(currently fails on pre-existingpackages/hermes-ink/src/ink/dom.tserror unrelated to this PR)