fix(cron): #13288 inherit runtime provider defaults on job create#14555
Open
MaHaoHao-ch wants to merge 1 commit into
Open
fix(cron): #13288 inherit runtime provider defaults on job create#14555MaHaoHao-ch wants to merge 1 commit into
MaHaoHao-ch wants to merge 1 commit into
Conversation
Ensure gateway-created cron jobs persist runtime provider/base_url defaults when not explicitly supplied, preventing fallback to invalid legacy provider values in execution. Closes NousResearch#13288
Collaborator
f09257a to
6965d80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes cron jobs created from gateway sessions (for example Weixin) inheriting an invalid legacy provider at execution time.
When
providerorbase_urlis omitted oncronjob(action="create"), the tool now resolves runtime defaults from the active session and persists them into the job.Related Issue
Fixes #13288
Type of Change
Changes Made
tools/cronjob_tools.pyto resolve runtime defaults for cron create whenprovider/base_urlare not explicitly passed.providerandbase_urlvalues when users provide them.tests/tools/test_cronjob_tools.pyfor gateway-session inheritance and explicit-override preservation.How to Test
uv run --frozen --python 3.11 --extra dev pytest -o addopts= tests/tools/test_cronjob_tools.py -qtest_create_inherits_runtime_provider_when_missingtest_create_preserves_explicit_provider_and_base_urlChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
uv run --frozen --python 3.11 --extra dev pytest -o addopts= tests/tools/test_cronjob_tools.py -q->27 passed