Skip to content

fix(cron): inherit config runtime provider for jobs#13171

Open
tangyuanjc wants to merge 1 commit into
NousResearch:mainfrom
tangyuanjc:fix/cron-config-provider-inheritance
Open

fix(cron): inherit config runtime provider for jobs#13171
tangyuanjc wants to merge 1 commit into
NousResearch:mainfrom
tangyuanjc:fix/cron-config-provider-inheritance

Conversation

@tangyuanjc

Copy link
Copy Markdown

Summary

  • let cron jobs inherit the runtime provider configured in config.yaml when the job omits provider
  • preserve config model.base_url for custom providers unless the job overrides it
  • add a regression test covering config runtime inheritance over env overrides

Testing

  • pytest -o addopts='' tests/cron/test_scheduler.py -k "config_runtime_over_env_override or bad_config_yaml_is_logged or bad_prefill_messages_is_logged"

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cron Cron scheduler and job management area/config Config system, migrations, profiles labels Apr 22, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Related to #13337 which fixes the same provider inheritance issue for gateway-created cron jobs. May overlap — maintainers should check if one subsumes the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cron Cron scheduler and job management P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants