fix(skills): preserve modes during atomic writes#14410
Open
sgaofen wants to merge 1 commit into
Open
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14181.
This preserves file permissions when Hermes rewrites skill runtime files through atomic temp-file replacement.
Root cause
tempfile.mkstemp()creates replacement files as0600. Bothskill_managewrites and bundled skill manifest writes then usedos.replace()directly, so existing group-readable/group-writable files could be silently recreated as owner-private files in managed/shared deployments.Fix
SKILL.mdor.bundled_manifest.mkstemp()default.skill_manageatomic writes andskills_syncmanifest writes preserving0660files.Validation
/Users/stephenyu/Documents/hermes-agent/.venv/bin/python -m pytest tests/tools/test_skill_manager_tool.py::TestAtomicWriteText::test_preserves_existing_file_mode tests/tools/test_skills_sync.py::TestReadWriteManifest::test_write_manifest_preserves_existing_file_mode -q --tb=short/Users/stephenyu/Documents/hermes-agent/.venv/bin/python -m pytest tests/tools/test_skill_manager_tool.py tests/tools/test_skills_sync.py -q --tb=shortgit diff --check