fix(skills): preserve file modes across atomic writes#14280
Closed
liuhao1024 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing inactive PR with no discussion. Opened 2026-04-23 with 0 comments. Will reopen if still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve existing file permissions when skill writes and bundled skill manifest updates replace files atomically.
Before this change, both
tools.skill_manager_tool._atomic_write_text()andtools.skills_sync._write_manifest()rewrote existing files throughmkstemp()+os.replace()without restoring the original mode first. That letSKILL.mdand.bundled_manifestcollapse to0600, which breaks managed/shared Hermes runtimes that expect group-readable files.Root cause
tempfile.mkstemp()creates the temp file with owner-only permissions.os.replace()then swaps that temp file into place, so the target inherits the temp file mode unless the write path explicitly preserves the old mode.Fix
os.replace()Regression coverage
Added focused tests that verify both write paths preserve an existing
0664mode, including the temp file mode at replace time:tools.skill_manager_tool._atomic_write_text()forSKILL.mdtools.skills_sync._write_manifest()for.bundled_manifestTesting
scripts/run_tests.sh tests/tools/test_atomic_write_permissions.py -qscripts/run_tests.sh tests/tools/test_skill_manager_tool.py -qscripts/run_tests.sh tests/tools/test_skills_sync.py -qCloses #14181