fix(gateway): remove extraneous code merged by accident#1428
Closed
jplew wants to merge 2 commits into
Closed
Conversation
teknium1
added a commit
that referenced
this pull request
Mar 16, 2026
…richment (#1529) Salvaged from PR #1428 by jplew. Removes Athabasca-specific persistence guidance accidentally merged in PR #1422: - Drop Athabasca docstring and injected note from _enrich_message_with_vision - Delete tests/gateway/test_image_enrichment.py (asserted app-specific behavior) Co-authored-by: jplew <jplew@users.noreply.github.com>
Contributor
|
Merged via PR #1529. Your commits were cherry-picked onto current main with authorship preserved. Clean apply, no conflicts. Thanks for the cleanup! |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…richment (NousResearch#1529) Salvaged from PR NousResearch#1428 by jplew. Removes Athabasca-specific persistence guidance accidentally merged in PR NousResearch#1422: - Drop Athabasca docstring and injected note from _enrich_message_with_vision - Delete tests/gateway/test_image_enrichment.py (asserted app-specific behavior) Co-authored-by: jplew <jplew@users.noreply.github.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…richment (NousResearch#1529) Salvaged from PR NousResearch#1428 by jplew. Removes Athabasca-specific persistence guidance accidentally merged in PR NousResearch#1422: - Drop Athabasca docstring and injected note from _enrich_message_with_vision - Delete tests/gateway/test_image_enrichment.py (asserted app-specific behavior) Co-authored-by: jplew <jplew@users.noreply.github.com>
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…richment (NousResearch#1529) Salvaged from PR NousResearch#1428 by jplew. Removes Athabasca-specific persistence guidance accidentally merged in PR NousResearch#1422: - Drop Athabasca docstring and injected note from _enrich_message_with_vision - Delete tests/gateway/test_image_enrichment.py (asserted app-specific behavior) Co-authored-by: jplew <jplew@users.noreply.github.com>
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…richment (NousResearch#1529) Salvaged from PR NousResearch#1428 by jplew. Removes Athabasca-specific persistence guidance accidentally merged in PR NousResearch#1422: - Drop Athabasca docstring and injected note from _enrich_message_with_vision - Delete tests/gateway/test_image_enrichment.py (asserted app-specific behavior) Co-authored-by: jplew <jplew@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A prior PR (#1422) for Telegram photo burst interrupts accidentally included some of my app-specific (Athabasca) implementation guidance in
gateway/run.pyand an unrelated test filetests/gateway/test_image_enrichment.py.This is just noise and should be deleted, it was just customization meant for my specific use-case.
This PR cleans up the remaining Athabasca-specific references and removes the unrelated test file to ensure the codebase remains generic.
Changes
_enrich_message_with_visioningateway/run.py.tests/gateway/test_image_enrichment.pywhich was accidentally merged and contains app-specific assertions.Fixes part of #1409 (cleanup).