fix(terminal): use TERMINAL_CWD for local backend default_cwd#14264
Closed
ms-alan wants to merge 4 commits into
Closed
fix(terminal): use TERMINAL_CWD for local backend default_cwd#14264ms-alan wants to merge 4 commits into
ms-alan wants to merge 4 commits into
Conversation
added 4 commits
April 23, 2026 09:17
Fixes 'no such column' errors when fact_store search receives hyphenated identifiers like 'pve-01' by wrapping bare hyphenated tokens in double quotes before passing to FTS5 MATCH. Closes NousResearch#14024
Previously, the 'local' backend always defaulted to os.getcwd() regardless of the terminal.cwd config / TERMINAL_CWD env var, because the local branch set default_cwd before the shared TERMINAL_CWD lookup. Now the local branch also respects TERMINAL_CWD when set. Closes NousResearch#14044
Collaborator
This was referenced Apr 23, 2026
Collaborator
|
Broad file changes flagged. |
19 tasks
Contributor
|
Thanks for the contribution @ms-alan! Closing — the premise here doesn't hold on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the 'local' backend always defaulted to os.getcwd() regardless of the terminal.cwd config / TERMINAL_CWD env var, because the local branch set default_cwd before the shared TERMINAL_CWD lookup. Now the local branch also respects TERMINAL_CWD when set.
Closes #14044