Skip to content

fix(cli): load_cli_config() overwrites gateway's TERMINAL_CWD from MESSAGING_CWD#10252

Closed
EdderTalmor wants to merge 1 commit into
NousResearch:mainfrom
EdderTalmor:fix/issue-10225
Closed

fix(cli): load_cli_config() overwrites gateway's TERMINAL_CWD from MESSAGING_CWD#10252
EdderTalmor wants to merge 1 commit into
NousResearch:mainfrom
EdderTalmor:fix/issue-10225

Conversation

@EdderTalmor

Copy link
Copy Markdown

Closes #10225

Summary

  • Preserve an already-set TERMINAL_CWD when terminal.cwd is . / auto / cwd for local backends.
  • Fall back to os.getcwd() only when no valid terminal cwd is already present.
  • Added tests covering both the preserved and fallback cases.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery labels Apr 26, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #10226 — same fix: preserve existing TERMINAL_CWD instead of overwriting from MESSAGING_CWD in load_cli_config().

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the contribution @EdderTalmor! This fix has already landed on main via a broader CWD refactor.

This is an automated hermes-sweeper review.

The fix shipped as part of a larger unification that made config.yaml terminal.cwd the single source of truth for working directory. Closing as implemented on main.

@teknium1 teknium1 closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): load_cli_config() overwrites gateway's TERMINAL_CWD from MESSAGING_CWD

3 participants