fix(cli): load_cli_config() overwrites gateway's TERMINAL_CWD from MESSAGING_CWD#10252
Closed
EdderTalmor wants to merge 1 commit into
Closed
fix(cli): load_cli_config() overwrites gateway's TERMINAL_CWD from MESSAGING_CWD#10252EdderTalmor wants to merge 1 commit into
EdderTalmor wants to merge 1 commit into
Conversation
Collaborator
|
Likely duplicate of #10226 — same fix: preserve existing TERMINAL_CWD instead of overwriting from MESSAGING_CWD in load_cli_config(). |
Contributor
|
Thanks for the contribution @EdderTalmor! This fix has already landed on This is an automated hermes-sweeper review.
The fix shipped as part of a larger unification that made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10225
Summary
terminal.cwdis./auto/cwdfor local backends.os.getcwd()only when no valid terminal cwd is already present.