fix(tui): delegate unknown /tools subcommand to slash.exec#13595
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes /tools behavior in the TUI so non-enable/disable subcommands (e.g. /tools list) are executed via the existing slash.exec backend path instead of silently doing nothing.
Changes:
- Route
/tools <subcommand>toslash.execunless the subcommand isenableordisable. - Preserve the client-local
enable/disableflow to keep session history reset behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b64f8a1 to
41e42fd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
/tools' local handler silently returned for anything other than enable or disable, so /tools list and friends looked broken even though the Python CLI already implements them (hermes_cli/main.py registers tools_sub for list/enable/disable). Keep the client-owned enable/disable path (which has to run session.setSessionStartedAt + resetVisibleHistory locally) and route every other sub through slash.exec, matching createSlashHandler's page/sys split for long vs short output.
158b5f9 to
83c1d4e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ulasbilgen
pushed a commit
to ulasbilgen/hermes-adhd-agent
that referenced
this pull request
May 1, 2026
…unknown-subcommand fix(tui): delegate unknown /tools subcommand to slash.exec
aj-nt
pushed a commit
to aj-nt/hermes-agent
that referenced
this pull request
May 1, 2026
…unknown-subcommand fix(tui): delegate unknown /tools subcommand to slash.exec
Luminet2023
pushed a commit
to Luminet2023/hermes-agent
that referenced
this pull request
May 1, 2026
…unknown-subcommand fix(tui): delegate unknown /tools subcommand to slash.exec
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…unknown-subcommand fix(tui): delegate unknown /tools subcommand to slash.exec
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…unknown-subcommand fix(tui): delegate unknown /tools subcommand to slash.exec
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…unknown-subcommand fix(tui): delegate unknown /tools subcommand to slash.exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From TUI blitz-test feedback: "
/tools listseems not to show anything."Summary
/tools's local handler silently returned for any subcommand other thanenable/disable, so/tools listlooked broken even though the Python CLI already implements it (hermes_cli/main.pyregisterstools_subfor list/enable/disable).session.setSessionStartedAt+resetVisibleHistorylocally) and route every other sub throughslash.exec, mirroringcreateSlashHandler's page/sys split for long vs short output.Test plan
npm run type-checkcleannpm test— 152/152 pass/tools list— expect the enabled/disabled table/tools enable web//tools disable web— still hits local path and resets visible history